Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX][l10n_it_fatturapa_in] do not fail import of XML e-invoice on missing/wrong bank account information #4219

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[14.0][FIX][l10n_it_fatturapa_in] do not fail import of XML e-invoice on missing/wrong bank account information #4219

merged 1 commit into from
Oct 21, 2024

Conversation

matteoopenf
Copy link
Contributor

@matteoopenf matteoopenf commented Jun 20, 2024 •
edited
Loading

Porting di #1979

@matteoopenf matteoopenf force-pushed the 14.0-Porting_Orfrom12-1979 branch from b44ba0e to 3364ff2 Compare June 20, 2024 08:02
@matteoopenf
Copy link
Contributor Author

@TheMule71 Sto facendo il porting della tua pr, pensavo appena finisco di testare tutto di schiacciare tutto nel primo commit per te va bene?

@matteoopenf matteoopenf mentioned this pull request Jun 20, 2024
Open
3 tasks
@francesco-ooops francesco-ooops linked an issue Jun 20, 2024 that may be closed by this pull request
[l10n_it_fatturapa_in] importazione conto in caso di riba errore duplicazione conto #4220
Open
3 tasks
@matteoopenf matteoopenf force-pushed the 14.0-Porting_Orfrom12-1979 branch from 665b9c0 to 107ad2e Compare June 20, 2024 09:08
@matteoopenf matteoopenf marked this pull request as ready for review June 20, 2024 09:08
@matteoopenf
Copy link
Contributor Author

@tafaRU tu cosa ne pensi che schiaccio tutto in unico commit? cosi poi in caso e' pronta la pr

@francesco-ooops
Copy link
Contributor

Se per @TheMule71 va bene squasha pure, puoi approfittarne per dare un nome più rilevante al commit

@matteoopenf
Copy link
Contributor Author

Se per @TheMule71 va bene squasha pure, puoi approfittarne per dare un nome più rilevante al commit

appena mi da conferma procedo subito che in locale sono su questo branch

TheMule71
TheMule71 reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@TheMule71 TheMule71 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rimosso

TheMule71
TheMule71 reviewed Jun 20, 2024
View reviewed changes
l10n_it_fatturapa_in/wizard/wizard_import_fatturapa.py Outdated
@@ -843,9 +843,6 @@ def _createPaymentsLine(self, payment, line, partner_id, invoice_id):
)
)
val = {
"payment_term_start": dline.DataRiferimentoTerminiPagamento
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capisco la prima riga, che è ripetuta sotto, ma payment_bank? è effettivamente inutile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
eccolo e' preservato sta solo a una riga diversa se ho capito la tua domanda

@TheMule71
Copy link
Contributor

Se per @TheMule71 va bene squasha pure, puoi approfittarne per dare un nome più rilevante al commit

appena mi da conferma procedo subito che in locale sono su questo branch

Si, squasha pure.

@matteoopenf
Copy link
Contributor Author

matteoopenf commented Jun 20, 2024 via email

@matteoopenf matteoopenf force-pushed the 14.0-Porting_Orfrom12-1979 branch from 107ad2e to d95d0a5 Compare June 20, 2024 10:59
@matteoopenf
Copy link
Contributor Author

Se per @TheMule71 va bene squasha pure, puoi approfittarne per dare un nome più rilevante al commit

appena mi da conferma procedo subito che in locale sono su questo branch

Si, squasha pure.

fatto

@matteoopenf
Copy link
Contributor Author

ho anche rimesso il messaggio del tuo commit

@matteoopenf matteoopenf requested a review from TheMule71 June 20, 2024 11:18
@matteoopenf
Copy link
Contributor Author

la riporto un attimo in draft che testando in locale ho notato un paio di problemi

@matteoopenf matteoopenf marked this pull request as draft June 20, 2024 13:23
@matteoopenf matteoopenf force-pushed the 14.0-Porting_Orfrom12-1979 branch 2 times, most recently from 9f6d8df to c2c4249 Compare June 20, 2024 14:49
@matteoopenf matteoopenf marked this pull request as ready for review June 20, 2024 14:50
@matteoopenf
Copy link
Contributor Author

@TheMule71 ho finito i test e ho schiacciato definitivamente tutto in un commit, fammi sapere se e' tutto chiaro o meno e secondo me ci siamo

@matteoopenf
Copy link
Contributor Author

@TheMule71 ci siamo quindi per te?
cosi nel caso saremmo a due approvazioni poi

@matteoopenf
Copy link
Contributor Author

@TheMule71 ci siamo? cosi potremmo vedere per mergiare

@matteoopenf
Copy link
Contributor Author

@TheMule71 per caso ci siamo per te e possiamo mergiare?
Grazie Mille

@francesco-ooops francesco-ooops changed the title 14.0 porting orfrom12 1979 [14.0][FIX][l10n_it_fatturapa_in] do not fail import of XML e-invoice on missing/wrong bank account information Jul 18, 2024
@matteoopenf
Copy link
Contributor Author

@TheMule71 per caso riusciamo ad arrivare al merge?

@francesco-ooops
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@OCA-git-bot OCA-git-bot force-pushed the 14.0-Porting_Orfrom12-1979 branch from c2c4249 to 63f6dcd Compare August 9, 2024 09:01
@francesco-ooops
Copy link
Contributor

@OCA/local-italy-maintainers qualche anima pia può fare review?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

eLBati
eLBati reviewed Aug 29, 2024
View reviewed changes
l10n_it_fatturapa_in/wizard/wizard_import_fatturapa.py
"in",
(
partner_id,
invoice.company_id.partner_id.id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qui invoice è uguale a payment.invoice_id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dovrebbe esserlo, ma ho riportato il commit cosi com'è per mantenere la history, che poi il tutto parte da un commit che feci tu in una versione più vecchia, se non ricordo male.
La pr è simile a una tua vecchia #2272 forse ricordo male

@eLBati
Copy link
Member

eLBati commented Oct 4, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-4219-by-eLBati-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 4, 2024
@OCA-git-bot
Merge PR #4219 into 14.0
ccd04ae 
Signed-off-by eLBati
@OCA-git-bot
Copy link
Contributor

@eLBati your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-4219-by-eLBati-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@francesco-ooops
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@OCA-git-bot OCA-git-bot force-pushed the 14.0-Porting_Orfrom12-1979 branch from 63f6dcd to 2e0a72e Compare October 4, 2024 08:23
@matteoopenf
Copy link
Contributor Author

/ocabot merge patch

perfavore si potrebbe riprovare?

@SirAionTech
Copy link
Contributor

/ocabot merge patch

perfavore si potrebbe riprovare?

👍 /ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-4219-by-SirAionTech-bump-patch, awaiting test results.

@matteoopenf
Copy link
Contributor Author

/ocabot merge patch

perfavore si potrebbe riprovare?

👍 /ocabot merge patch

Grazie Mille

@OCA-git-bot OCA-git-bot merged commit 17f289d into OCA:14.0 Oct 21, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1747779. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati left review comments

@amosdisabatino amosdisabatino amosdisabatino approved these changes

@lorenzoallegrucci lorenzoallegrucci lorenzoallegrucci approved these changes

@TheMule71 TheMule71 Awaiting requested review from TheMule71

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[l10n_it_fatturapa_in] importazione conto in caso di riba errore duplicazione conto
8 participants
@matteoopenf @francesco-ooops @TheMule71 @OCA-git-bot @eLBati @SirAionTech @lorenzoallegrucci @amosdisabatino