Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] l10n_it_accompanying_invoice -> l10n_it_shipping_invoice: Migration to 16.0 #3742

Closed
wants to merge 5 commits into from
Closed

[MIG] l10n_it_accompanying_invoice -> l10n_it_shipping_invoice: Migration to 16.0 #3742

wants to merge 5 commits into from

Conversation

SirAionTech
Copy link
Contributor

Migrazione da https://github.com/OCA/l10n-italy/tree/8937e1406eb42768a820539a0f0d9e5e8f305188/l10n_it_accompanying_invoice (12.0), rinominato seguendo https://github.com/OCA/l10n-italy/wiki/Migrazione-con-rinomina-modulo,-compatibile-con-OpenUpgrade-e-Odoo-SA.

Prima dei commit del modulo migrato ho aggiunto un refactoring di l10n_it_delivery_note per esporre il template di stampa come veniva fatto in

l10n-italy/l10n_it_ddt/views/report_ddt.xml

Line 6 in 8937e14

<template id="delivery_data">
e un mixin per esporre i campi relativi alla spedizione.

@OCA-git-bot
Copy link
Contributor

Hi @MarcoCalcagni,
some modules you are maintaining are being modified, check this out!

@SirAionTech SirAionTech marked this pull request as ready for review November 28, 2023 10:59
@SirAionTech SirAionTech force-pushed the 16.0-mig-l10n_it_accompanying_invoice branch from 687d80a to 78d2c69 Compare February 29, 2024 09:06
MaurizioPellegrinet
MaurizioPellegrinet approved these changes Feb 29, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SirAionTech SirAionTech force-pushed the 16.0-mig-l10n_it_accompanying_invoice branch from 78d2c69 to 1f768ed Compare February 29, 2024 16:33
@SirAionTech
Copy link
Contributor Author

Rebase perché #4003 è stata risolta.

@SirAionTech SirAionTech force-pushed the 16.0-mig-l10n_it_accompanying_invoice branch from 1f768ed to cd3fdba Compare March 6, 2024 16:33
@SirAionTech
Copy link
Contributor Author

SirAionTech commented Mar 6, 2024 •
edited
Loading

Fatto rebase per risolvere i conflitti

@SirAionTech SirAionTech force-pushed the 16.0-mig-l10n_it_accompanying_invoice branch from cd3fdba to 922c7c7 Compare March 6, 2024 16:46
@SirAionTech SirAionTech changed the title [MIG] l10n_it_accompanying_invoice: Migration to 16.0 [MIG] l10n_it_accompanying_invoice -> l10n_it_shipping_invoice: Migration to 16.0 Mar 21, 2024
@SirAionTech SirAionTech force-pushed the 16.0-mig-l10n_it_accompanying_invoice branch from 922c7c7 to 0f4f624 Compare March 21, 2024 15:21
@SirAionTech
Copy link
Contributor Author

Fatto rebase per risolvere i conflitti

@SirAionTech
Copy link
Contributor Author

/ocabot migration l10n_it_accompanying_invoice

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 14, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 14, 2024
Open
79 tasks
@primes2h
Copy link
Contributor

Migrazione da https://github.com/OCA/l10n-italy/tree/8937e1406eb42768a820539a0f0d9e5e8f305188/l10n_it_accompanying_invoice (12.0), rinominato seguendo https://github.com/OCA/l10n-italy/wiki/Migrazione-con-rinomina-modulo,-compatibile-con-OpenUpgrade-e-Odoo-SA.

Come mai il modulo è stato rinominato?
Il termine "accompanying invoice" direi che era corretto, viene usato comunemente e si trova anche in molti software (es. SAP, Dynamics, Mago), nonché nei riferimenti del formato fatturapa dell'AdE.

https://www.tcodesearch.com/tcodes/search?q=goods+accompanying+invoice+for+customs+purposes
https://community.sap.com/t5/supply-chain-management-q-a/change-owner-with-accompanying-invoice-without-stock-movement/qaq-p/10439047
https://community.dynamics.com/forums/thread/details/?threadid=6cdd4711-a637-4161-989b-7b1e7c77b771
https://www.mago-erp.com/wp-content/uploads/2021/12/Mago4_ERP_module_purchases.pdf
https://www.dhl.com/it-en/home/express/news/brexit.html
https://www.fatturapa.gov.it/export/documenti/fatturapa/v1.2.1/Table-view-B2B-Ordinary-invoice.pdf

@SirAionTech
Copy link
Contributor Author

Migrazione da https://github.com/OCA/l10n-italy/tree/8937e1406eb42768a820539a0f0d9e5e8f305188/l10n_it_accompanying_invoice (12.0), rinominato seguendo https://github.com/OCA/l10n-italy/wiki/Migrazione-con-rinomina-modulo,-compatibile-con-OpenUpgrade-e-Odoo-SA.

Come mai il modulo è stato rinominato? Il termine "accompanying invoice" direi che era corretto, viene usato comunemente e si trova anche in molti software (es. SAP, Dynamics, Mago), nonché nei riferimenti del formato fatturapa dell'AdE.

https://www.tcodesearch.com/tcodes/search?q=goods+accompanying+invoice+for+customs+purposes https://community.sap.com/t5/supply-chain-management-q-a/change-owner-with-accompanying-invoice-without-stock-movement/qaq-p/10439047 https://community.dynamics.com/forums/thread/details/?threadid=6cdd4711-a637-4161-989b-7b1e7c77b771 https://www.mago-erp.com/wp-content/uploads/2021/12/Mago4_ERP_module_purchases.pdf https://www.dhl.com/it-en/home/express/news/brexit.html https://www.fatturapa.gov.it/export/documenti/fatturapa/v1.2.1/Table-view-B2B-Ordinary-invoice.pdf

Vediamo che ne dice @dcorio

@francesco-ooops
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-mig-l10n_it_accompanying_invoice branch from 0f4f624 to 37862c6 Compare July 9, 2024 10:47
FrancescoBallerini
FrancescoBallerini approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@FrancescoBallerini FrancescoBallerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional: LGTM

Code: sarebbe utile se venissero valorizzati i pesi lordo e netto come accade qui nel DDT
https://github.com/OCA/l10n-italy/blob/16.0/l10n_it_delivery_note/models/stock_delivery_note.py#L340-L358

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@dcorio @primes2h sblocchiamo la questione terminologica?

@andreampiovesana
Copy link
Contributor

Sia @dcorio che @primes2h sentiti oggi, concordano di usare il nome l10n_it_accompanying_invoice

@dcorio
Copy link
Contributor

dcorio commented Jul 12, 2024

Confermo. Ho introdotto io la confusione, ma il termine corretto è accompanying e non shipping

@primes2h
Copy link
Contributor

primes2h commented Jul 12, 2024 •
edited
Loading

Confermo anch'io, aggiungo solo un chiarimento a riguardo.
In generale potrebbero andare bene entrambe le traduzioni ma nel caso specifico terrei il termine "shipping invoice" come traduzione di "fattura di spedizione".
In questo modo evitiamo alla radice eventuali problematiche di traduzione contestuali, semplificando non di poco il lavoro dei traduttori.

@andreampiovesana
Copy link
Contributor

@SirAionTech elimini tu il rename?

@SirAionTech
Copy link
Contributor Author

@SirAionTech elimini tu il rename?

Non prossimamente

@andreampiovesana
Copy link
Contributor

no news?

@odooNextev
Copy link
Contributor

@SirAionTech se è solo da rinominare il modulo posso farlo io.
Fammi sapere perchè molto probabilmente mi serve a breve da un cliente.

@SirAionTech
Copy link
Contributor Author

@SirAionTech se è solo da rinominare il modulo posso farlo io. Fammi sapere perchè molto probabilmente mi serve a breve da un cliente.

Continua a non essere in previsione

@odooNextev odooNextev mentioned this pull request Aug 8, 2024
Merged
@SirAionTech
Copy link
Contributor Author

Viene portata avanti in #4321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

@FrancescoBallerini FrancescoBallerini FrancescoBallerini approved these changes

Assignees
No one assigned
Labels
16.0 approved migration ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.