16.0 mig l10n fr ecotaxe #448

mourad-ehm · 2023-05-15T15:33:22Z

No description provided.

legalsylvain · 2023-06-09T20:23:56Z

/ocabot migration l10n_fr_ecotaxe

pfranck · 2023-06-29T07:57:45Z

Any help needed to merge the request ?

pfranck · 2023-09-06T06:11:59Z

Any solution to be able to merge this request

florian-dacosta

I did a quick code review, just some minor remarks.
When the PR is ready I will do some tests

florian-dacosta · 2023-11-24T10:50:29Z

l10n_fr_ecotaxe/models/account_ecotaxe_classification.py

+    ecotaxe_scale_code = fields.Char()
+
+    @api.onchange("ecotaxe_type")
+    def _onchange_ecotaxe_type(self):


Would be nice to convert default_fixed_ecotaxe and ecotaxe_coef as readonly=False computed fields to replace this on change.

florian-dacosta · 2023-11-24T10:55:49Z

l10n_fr_ecotaxe/models/ecotaxe_line_product.py

+
+
+class EcotaxeLineProduct(models.Model):
+    """class for objects which can be used to save mutili ecotaxe calssification  by product."""


mutili = multi

l10n_fr_ecotaxe/models/ecotaxe_line_product.py

bealdav

Partial review

bealdav · 2023-12-14T13:15:08Z

l10n_fr_ecotaxe/views/product_view.xml

+                            readonly="1"
+                        >
+                            <tree editable="bottom">
+                                <field name="ecotaxe_classification_id" />


Just for usability

We already know it's Ecotax because this is the name of th o2m

Suggested change

<field name="ecotaxe_classification_id" />

<field name="ecotaxe_classification_id" string="Classification" />

bealdav · 2023-12-14T13:17:05Z

l10n_fr_ecotaxe/views/product_view.xml

+                            <tree editable="bottom">
+                                <field name="ecotaxe_classification_id" />
+                                <field name="force_ecotaxe_amount" />
+                                <field name="ecotaxe_amount" />


Suggested change

<field name="ecotaxe_amount" />

<field name="ecotaxe_amount" string="Amount" />

bealdav · 2023-12-14T13:18:09Z

l10n_fr_ecotaxe/views/product_view.xml

+                            <tree editable="bottom">
+                                <field name="ecotaxe_classification_id" />
+                                <field name="force_ecotaxe_amount" />
+                                <field name="ecotaxe_amount" />


Same here for name field

bealdav · 2023-12-20T09:42:50Z

l10n_fr_ecotaxe/models/ecotaxe_line_mixin.py

+
+    product_id = fields.Many2one("product.product", string="Product", readonly=True)
+    currency_id = fields.Many2one("res.currency", string="Currency")
+    ecotaxe_classification_id = fields.Many2one(


Because it's an ecotaxe model, maybe classification_id name is sufficient here

bealdav · 2023-12-20T09:43:08Z

l10n_fr_ecotaxe/models/ecotaxe_line_mixin.py

+        "account.ecotaxe.classification",
+        string="Ecotaxe Classification",
+    )
+    ecotaxe_amount_unit = fields.Monetary(


Because it's an ecotaxe model, maybe amount_unit name is sufficient here.

The same for ecotaxe name in fields below

l10n_fr_ecotaxe/models/account_move_line_ecotaxe.py

metaminux · 2024-01-30T14:53:42Z

l10n_fr_ecotaxe/models/product_product.py

+        "ecotaxe.line.product",
+        compute="_compute_all_ecotaxe_line_product_ids",
+        search="_search_all_ecotaxe_line_product_ids",
+        string="Additional ecotaxe lines",


Suggested change

string="Additional ecotaxe lines",

string="All ecotaxe lines",

To avoid Warning : Two fields (all_ecotaxe_line_product_ids, additional_ecotaxe_line_product_ids) of product.product() have the same label: Additional ecotaxe lines.

…product and ecotaxe classification

bealdav

lgtm

metaminux

LGTM too

OCA-git-bot · 2024-02-20T10:50:56Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[14.0][IMP] l10n_fr_ecotaxe: manage multi ecotaxe classification by product [14.0][FIX] l10n_fr_ecotaxe: pre-commit, access rule, view [14.0][FIX] l10n_fr_ecotaxe: imp multi ecotaxe classification on product form & edit ecotaxe line on account move line [14.0][FIX] l10n_fr_ecotaxe: add archived web_ribbon on ecotaxe_classification & ecotaxe_category [14.0][FIX] l10n_fr_ecotaxe: fix tests [14.0][FIX] l10n_fr_ecotaxe: fix _onchange_product_ecotaxe_line [16.0][FIX] fix pre-commit & typo [16.0][FIX] update readme files

[16.0][FIX] product variant view [16.0][FIX] add unique sql constaint for ecotaxe classif on product

[16.0][IMP] rename fields in l10n_fr_ecotaxe module rest of modif & imp product view

[16.0][FIX] fix psot-migration view load bug [16.0][FIX] fix digits precision for ecotaxe amount on invoice & product & fixed ecotaxe [16.0][FIX] tests [16.0][FIX] replace onchange by compute [16.0][FIX] pre-commit

gurneyalex · 2024-06-05T12:04:42Z

/ocabot merge nobump

OCA-git-bot · 2024-06-05T12:05:08Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-448-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot · 2024-06-05T12:13:25Z

Congratulations, your PR was merged at 5712b78. Thanks a lot for contributing to OCA. ❤️

bealdav · 2024-06-05T12:56:19Z

Oops these modules has been hardly modified here

OCA/account-fiscal-rule#428
OCA/account-fiscal-rule#429

Inside Ecotax use tax odoo mechanism

gurneyalex · 2024-06-05T14:42:57Z

hello @bealdav sorry I had missed the discussion on #483 and the PRs you mention.

I just updated #373 and #487 with the information of the moving the modules.

I'm not sure what the best course is here.

gurneyalex · 2024-06-05T14:50:17Z

#552 is reverting this

bealdav · 2024-06-05T16:11:41Z

It's our own fault. We had not a really good communication on it, sorry.

This was referenced May 22, 2023

16.0 mig l10n fr ecotaxe sale #449

Closed

16.0 mig l10n fr ecotaxe product #450

Closed

PaulGoubert approved these changes Jun 2, 2023

View reviewed changes

legalsylvain added this to the 16.0 milestone Jun 9, 2023

OCA-git-bot mentioned this pull request Jun 9, 2023

Migration to version 16.0 #373

Open

29 tasks

PaulGoubert approved these changes Jul 3, 2023

View reviewed changes

mourad-ehm mentioned this pull request Nov 23, 2023

16.0 mig l10n fr ecotaxe sale #493

Closed

florian-dacosta reviewed Nov 24, 2023

View reviewed changes

bealdav reviewed Dec 20, 2023

View reviewed changes

florian-dacosta reviewed Dec 29, 2023

View reviewed changes

l10n_fr_ecotaxe/models/account_move_line_ecotaxe.py Show resolved Hide resolved

metaminux suggested changes Jan 30, 2024

View reviewed changes

mourad-ehm added 14 commits February 20, 2024 09:59

Add custome profile module + account config

f66aeb3

FIX bug compute ecotaxe

bc9d998

Add ecotaxe classification

ddfb497

ADD eco taxes classification

246d71b

Remove commented code

3a140b4

[FIX] bug non compliant picking location dest

48ad66f

Add base exotaxe (weight or qty) + change relation many2many between …

0acd7cd

…product and ecotaxe classification

[FIX] compute generic base for account.invoice.taxe

7f40fba

[FIX] bug off binary fileds + code format

5782f7b

[FIX] move ecotaxte to product template

20d489a

[FIX] Clean Code

cf1fc17

[FIX] Add on change ecotaxe classification on product template

158a29d

[FIX] pylint code

1c87074

Fix Typo

3b3d709

mourad-ehm added 2 commits February 20, 2024 09:59

[IMP] l10n_fr_ecotaxe: pre-commit execution

8ce2743

[MIG] l10n_fr_ecotaxe: Migration to 16.0

f065dad

mourad-ehm force-pushed the 16.0-mig-l10n_fr_ecotaxe branch from 3ab46d6 to afe3a00 Compare February 20, 2024 09:00

PaulGoubert approved these changes Feb 20, 2024

View reviewed changes

bealdav approved these changes Feb 20, 2024

View reviewed changes

metaminux approved these changes Feb 20, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 20, 2024

mourad-ehm and others added 8 commits March 4, 2024 11:16

[16.0][IMP] manage ecotaxe for product variants

19fec37

[16.0][IMP] add ecotaxe sector and collector

d7c7cf9

[16.0][FIX] l10n_fr_ecotaxe: don't display ecotaxe on vendor invoices

da51838

[FIX] Add read rights for reaonly accounting group

5248178

[16.0][FIX] pre-commit

cd691c9

[16.0][FIX] product variant view [16.0][FIX] add unique sql constaint for ecotaxe classif on product

[16.0][IMP] rename fields in l10n_fr_ecotaxe module

38f0f04

[16.0][IMP] rename fields in l10n_fr_ecotaxe module rest of modif & imp product view

[16.0][FIX] fix amount digits precision & view update error

a046ea6

[16.0][FIX] fix psot-migration view load bug [16.0][FIX] fix digits precision for ecotaxe amount on invoice & product & fixed ecotaxe [16.0][FIX] tests [16.0][FIX] replace onchange by compute [16.0][FIX] pre-commit

mourad-ehm force-pushed the 16.0-mig-l10n_fr_ecotaxe branch from 118ef15 to a046ea6 Compare March 4, 2024 10:18

yankinmax mentioned this pull request Jun 3, 2024

[17.0][MIG] l10n_fr_ecotaxe: Migration to 17.0 #550

Merged

1 task

OCA-git-bot added the bot is merging ⏳ label Jun 5, 2024

OCA-git-bot merged commit e387934 into OCA:16.0 Jun 5, 2024
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

16.0 mig l10n fr ecotaxe #448

16.0 mig l10n fr ecotaxe #448

mourad-ehm commented May 15, 2023

legalsylvain commented Jun 9, 2023

pfranck commented Jun 29, 2023

pfranck commented Sep 6, 2023

florian-dacosta left a comment

florian-dacosta Nov 24, 2023

florian-dacosta Nov 24, 2023

bealdav left a comment

bealdav Dec 14, 2023

bealdav Dec 14, 2023

bealdav Dec 14, 2023

bealdav Dec 20, 2023

bealdav Dec 20, 2023 •

edited

Loading

metaminux Jan 30, 2024

bealdav left a comment

metaminux left a comment

OCA-git-bot commented Feb 20, 2024

gurneyalex commented Jun 5, 2024

OCA-git-bot commented Jun 5, 2024

OCA-git-bot commented Jun 5, 2024

bealdav commented Jun 5, 2024

gurneyalex commented Jun 5, 2024

gurneyalex commented Jun 5, 2024

bealdav commented Jun 5, 2024



		class EcotaxeLineProduct(models.Model):
		"""class for objects which can be used to save mutili ecotaxe calssification by product."""

	<field name="ecotaxe_classification_id" />
	<field name="ecotaxe_classification_id" string="Classification" />

	<field name="ecotaxe_amount" />
	<field name="ecotaxe_amount" string="Amount" />

	string="Additional ecotaxe lines",
	string="All ecotaxe lines",

16.0 mig l10n fr ecotaxe #448

16.0 mig l10n fr ecotaxe #448

Conversation

mourad-ehm commented May 15, 2023

legalsylvain commented Jun 9, 2023

pfranck commented Jun 29, 2023

pfranck commented Sep 6, 2023

florian-dacosta left a comment

Choose a reason for hiding this comment

florian-dacosta Nov 24, 2023

Choose a reason for hiding this comment

florian-dacosta Nov 24, 2023

Choose a reason for hiding this comment

bealdav left a comment

Choose a reason for hiding this comment

bealdav Dec 14, 2023

Choose a reason for hiding this comment

bealdav Dec 14, 2023

Choose a reason for hiding this comment

bealdav Dec 14, 2023

Choose a reason for hiding this comment

bealdav Dec 20, 2023

Choose a reason for hiding this comment

bealdav Dec 20, 2023 • edited Loading

Choose a reason for hiding this comment

metaminux Jan 30, 2024

Choose a reason for hiding this comment

bealdav left a comment

Choose a reason for hiding this comment

metaminux left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Feb 20, 2024

gurneyalex commented Jun 5, 2024

OCA-git-bot commented Jun 5, 2024

OCA-git-bot commented Jun 5, 2024

bealdav commented Jun 5, 2024

gurneyalex commented Jun 5, 2024

gurneyalex commented Jun 5, 2024

bealdav commented Jun 5, 2024

bealdav Dec 20, 2023 •

edited

Loading