[14.0][RFC] l10n_br_nfe: refactor nfce qrcode methods #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @renatonlima, @rvalyi, |
|
cc @mileo |
|
@marcelsavegnago pode dar rebase? |
marcelsavegnago
force-pushed
the
14.0-l10n_br_nfe-add-document_qrcode-and-refactor
branch
from
57b90f0 to
cbd2e6f
Compare
@rvalyi Done |
mileo
reviewed
Dec 5, 2024
| for record in self.filtered(lambda d: d.document_type == MODELO_FISCAL_NFCE): | ||
| record.nfe40_infNFeSupl = self.env[ | ||
| "l10n_br_fiscal.document.supplement" | ||
| ].create( |
There was a problem hiding this comment.
Ao reconfirmar o documento isso não será gerado em duplicidade?
There was a problem hiding this comment.
Estava pensando nisso esses dias tbm.. nao tem nenhuma checagem se ja existe algum registro, pelo que vi, simplesmente eh criado outro registro.. ou seja, provavelmente tem registro perdido nesta tabela.
There was a problem hiding this comment.
@mileo se teu time puder entrar no assunto, pode matar esta PR e criar outra.. ou manda os commits pra mim e eu mesclo.. criei ela apenas para nao deixar este assunto perdido.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends #3508