Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] l10n_br_account: state tests when no EDI #3496

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Nov 16, 2024

since #3012 when l10n_br_fiscal_edi is not installed, these tests were failing

errors were like:

2024-11-16 15:58:18,513 19216 INFO odoo16 odoo.addons.l10n_br_account.tests.test_account_move_lc: Starting AccountMoveLucroPresumido.test_change_states ...
2024-11-16 15:58:18,752 19216 INFO odoo16 odoo.addons.l10n_br_account.tests.test_account_move_lc: ======================================================================
2024-11-16 15:58:18,752 19216 ERROR odoo16 odoo.addons.l10n_br_account.tests.test_account_move_lc: FAIL: AccountMoveLucroPresumido.test_change_states
Traceback (most recent call last):
  File "/home/rvalyi/DEV/odoo16/odoo/external-src/l10n-brazil/l10n_br_account/tests/test_account_move_lc.py", line 1719, in test_change_states
    self.assertEqual(document_id.state, "a_enviar")
AssertionError: 'em_digitacao' != 'a_enviar'
- em_digitacao
+ a_enviar

(when l10n_br_fiscal_edi is installed there was no issue but it's still required the l10n_br_account module can be tested independently, when doing migrations for instance)

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

@rvalyi rvalyi force-pushed the 14.0-fix-non-edi-account-tests branch 2 times, most recently from aadb0ff to 2f76c7b Compare November 16, 2024 20:48
since OCA#3012
when l10n_br_fiscal_edi is not installed, these tests were failing
@rvalyi rvalyi force-pushed the 14.0-fix-non-edi-account-tests branch from 2f76c7b to 5706018 Compare November 19, 2024 14:47
@rvalyi
Copy link
Member Author

rvalyi commented Nov 19, 2024

@antoniospneto eu tinha errado o PR quando vc revisou: eu tinha mudado a deteção da instalação do modulo l10n_br_fiscal_edi para algo que eu achava mais robusto, porem sem testar e tava errado. Eu corrigi com esse force-push https://github.com/OCA/l10n-brazil/compare/2f76c7b2711ee45ddf97170b5be3e68ec0ab4f3c..5706018d7008ba093da0b2ab3cc5cbc228971d12
pode revisar de novo?

@rvalyi rvalyi requested a review from antoniospneto November 19, 2024 15:23
@rvalyi
Copy link
Member Author

rvalyi commented Nov 19, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3496-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2ffc781 into OCA:14.0 Nov 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ad1271d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants