[14.0][ADD] l10n_br_cte: add new module #3492

marcelsavegnago · 2024-11-14T16:51:21Z

No description provided.

OCA-git-bot · 2024-11-14T16:51:27Z

Hi @renatonlima, @rvalyi,
some modules you are maintaining are being modified, check this out!

marcelsavegnago · 2024-11-14T17:59:02Z

Ainda vou ajustar os commits e deixar mais organizado.

marcelsavegnago · 2024-11-14T18:00:03Z

@mileo da uma olhada no arquivo de contribuintes e se tiver mais alguem me passa o nome e o email aqui por favor.

marcelsavegnago · 2024-11-14T18:00:44Z

@mileo por favor peça para seu time dar uma revisada.. por ora comentei os trechos da transmissao mas ja da para validar a geracao do xml.

marcelsavegnago · 2024-11-14T18:01:28Z

@rvalyi da uma olhada neste commit por favor e veja se faz sentido algo assim para voce.. df937a4

rvalyi · 2024-11-14T18:21:02Z

@rvalyi da uma olhada neste commit por favor e veja se faz sentido algo assim para voce.. df937a4

Então teve essa atualização importante #3127

Vale a pena testar se continua funcionando com essa atualização... talvez dar o merge dela primeiro ou pelo menos conferir num PR...

marcelsavegnago · 2024-11-14T18:26:11Z

@rvalyi da uma olhada neste commit por favor e veja se faz sentido algo assim para voce.. df937a4

Então teve essa atualização importante #3127

Vale a pena testar se continua funcionando com essa atualização... talvez dar o merge dela primeiro ou pelo menos conferir num PR...

vou dar mais uma tapa nas coisas para ter algo rodando bonitinho e ja testo com esta PR..

l10n_br_cte/README.rst

rvalyi

2 problemas nos meus testes superficiais:

1: faltou o menu de CTe:

2: erro quando usa o menu "all documents" e depois create:

marcelsavegnago · 2024-11-15T14:41:03Z

@rvalyi se puder efetuar novamente os testes eu agradeco.

rvalyi · 2024-11-15T15:31:46Z

@rvalyi se puder efetuar novamente os testes eu agradeco.

Ficou bastante melhor. Porem se vc for em Fiscal>Documents>All Documents>Create continua aquele erro:

Error:
Odoo Server Error

Traceback (most recent call last):
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
  File "/opt/odoo/odoo/http.py", line 696, in dispatch
    result = self._call_function(**self.params)
  File "/opt/odoo/odoo/http.py", line 370, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/opt/odoo/odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File "/opt/odoo/odoo/http.py", line 358, in checked_call
    result = self.endpoint(*a, **kw)
  File "/opt/odoo/odoo/http.py", line 919, in __call__
    return self.method(*args, **kw)
  File "/opt/odoo/odoo/http.py", line 544, in response_wrap
    response = f(*args, **kw)
  File "/opt/odoo/addons/web/controllers/main.py", line 1370, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/main.py", line 1362, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 406, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 391, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/addons/account/models/account_move.py", line 1170, in onchange
    return super(AccountMove, self.with_context(recursive_onchanges=False)).onchange(values, field_name, field_onchange)
  File "/opt/odoo/odoo/models.py", line 6296, in onchange
    parent[name] = record[name]
  File "/opt/odoo/odoo/models.py", line 5727, in __getitem__
    return self._fields[key].__get__(self, self.env.registry[self._name])
  File "/opt/odoo/odoo/fields.py", line 1043, in __get__
    self.compute_value(recs)
  File "/opt/odoo/odoo/fields.py", line 1199, in compute_value
    records._compute_field_value(self)
  File "/opt/odoo/addons/mail/models/mail_thread.py", line 410, in _compute_field_value
    return super()._compute_field_value(field)
  File "/opt/odoo/odoo/models.py", line 4089, in _compute_field_value
    odoo.fields.determine(field.compute, self)
  File "/opt/odoo/odoo/fields.py", line 86, in determine
    return needle(records, *args)
  File "/opt/odoo/odoo/fields.py", line 575, in _compute_related
    record[self.name] = self._process_related(value[self.related_field.name])
  File "/opt/odoo/odoo/models.py", line 5727, in __getitem__
    return self._fields[key].__get__(self, self.env.registry[self._name])
  File "/opt/odoo/odoo/fields.py", line 1050, in __get__
    raise ValueError("Compute method failed to assign %s.%s" % (record, self.name))
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 652, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/opt/odoo/odoo/http.py", line 317, in _handle_exception
    raise exception.with_traceback(None) from new_cause
ValueError: Compute method failed to assign l10n_br_fiscal.document(<NewId 0x7f4c16e9c3d0>,).cte40_vTPrest

Não testei muito ainda mas pelo menos vi esse...

mileo · 2024-12-10T13:52:05Z

l10n_br_cte/models/res_country_state.py

+    def match_or_create_m2o(self, rec_dict, parent_dict, model=None):
+        """If state not found, break hard, don't create it"""
+
+        if rec_dict.get("code"):
+            domain = [("code", "=", rec_dict.get("code")), ("ibge_code", "!=", False)]
+            match = self.search(domain, limit=1)
+            if match:
+                return match.id
+        return False


Aqui não precisamos chamar o super?

eu me tomei como base o que estava no modulo l10n_br_nfe, mas olhando agora, acredito que sim, falta o super tanto inclusive no l10n_br_nfe.. @rvalyi oq acha ?

a gente poderia, mas tb não vejo grande problema não chamar. Pois esse metodo tem um dispatch para cada model ou comodel e apenas retorna um registro caso der match. Ou seja se vc quiser sobrecarregar não teria muita coisa para fazer com o result do parent. Podemos ajustar isso depois... cc @antoniospneto

mileo · 2024-12-10T13:52:36Z

l10n_br_cte/models/res_partner.py

+                rec.phone = rec.cte40_fone
+
+    @api.model
+    def match_or_create_m2o(self, rec_dict, parent_dict, model=None):


Aqui também?

rvalyi

da para rolar merge, mas ai como vai ser nobump, @marcelsavegnago vc tem que dar uma incrementada nos módulos:

l10n_br_account (minor)
l10n_br_cte_spec (major eu diria)
l10n_br_fiscal (minor)
spec_driven_model (patch)

marcelsavegnago · 2024-12-10T14:21:05Z

da para rolar merge, mas ai como vai ser nobump, @marcelsavegnago vc tem que dar uma incrementada nos módulos:

l10n_br_account (minor)

l10n_br_cte_spec (major eu diria)

l10n_br_fiscal (minor)

spec_driven_model (patch)

@rvalyi done

mileo · 2024-12-10T14:25:19Z

Merge! Merge! Merge!

rvalyi

parabéns pelo trabalho ai! uma grande etapa na localização ainda*!
*But our princess is in another castle!

/ocabot merge nobump

OCA-git-bot · 2024-12-10T14:44:55Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3492-by-rvalyi-bump-nobump, awaiting test results.

OCA-git-bot · 2024-12-10T15:18:45Z

Congratulations, your PR was merged at 42929d8. Thanks a lot for contributing to OCA. ❤️

This was referenced Nov 14, 2024

[14.0][WIP][NEW] l10n_br_cte #2586

Closed

[WIP][14.0][ADD] l10n_br_cte rebased #3141

Closed

[WIP][ADD][14.0] l10n_br_cte: add new module #3151

Closed

[14.0][ADD] l10n_br_cte: add new module #3462

Closed

[WIP]l10n_br_cte - test #3482

Closed

marcelsavegnago force-pushed the 14.0-add-l10n_br_cte-rebased-multi_schema-refactor branch from e9383db to 778ea20 Compare November 14, 2024 17:55

marcelsavegnago marked this pull request as ready for review November 14, 2024 17:58

antoniospneto reviewed Nov 14, 2024

View reviewed changes

l10n_br_cte/README.rst Outdated Show resolved Hide resolved

antoniospneto reviewed Nov 14, 2024

View reviewed changes

l10n_br_cte/README.rst Outdated Show resolved Hide resolved

rvalyi requested changes Nov 14, 2024

View reviewed changes

marcelsavegnago force-pushed the 14.0-add-l10n_br_cte-rebased-multi_schema-refactor branch 11 times, most recently from 8117dc4 to 2b81e67 Compare November 19, 2024 15:00

marcelsavegnago added 8 commits December 10, 2024 10:48

[RFC] l10n_br_cte: refactor dacte report

505c771

[IMP] l10n_br_cte: add make pdf tests

b7a6f24

[IMP] l10n_br_cte: add dacte settings on company form

8ebcdc3

[IMP] l10n_br_cte: add Engenere on CONTRIBUTORS.rst file

0dca5f2

[RFC] l10n_br_cte: action and menu refactor

158e09a

[IMP] l10n_br_fiscal: add CT-e Menu and Action

20d7e62

[IMP] l10n_br_account: add CT-e Menu and Action

e03df27

[FIX] l10n_br_cte: bypass monta_qrcode and others

2839b7d

marcelsavegnago force-pushed the 14.0-add-l10n_br_cte-rebased-multi_schema-refactor branch from f59dba0 to 2839b7d Compare December 10, 2024 13:48

mileo reviewed Dec 10, 2024

View reviewed changes

mileo approved these changes Dec 10, 2024

View reviewed changes

rvalyi requested changes Dec 10, 2024

View reviewed changes

OCA-git-bot removed the approved label Dec 10, 2024

marcelsavegnago added 4 commits December 10, 2024 11:19

[IMP] l10n_br_cte_spec: bump version

fb1e42c

[IMP] l10n_br_account: bump version

a20bba2

[IMP] l10n_br_fiscal: bump version

ad0886f

[IMP] spec_driven_model: bump version

a15a128

marcelsavegnago requested a review from rvalyi December 10, 2024 14:28

rvalyi approved these changes Dec 10, 2024

View reviewed changes

OCA-git-bot added the approved label Dec 10, 2024

OCA-git-bot added the bot is merging ⏳ label Dec 10, 2024

OCA-git-bot merged commit 2ca24ba into OCA:14.0 Dec 10, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 10, 2024

marcelsavegnago deleted the 14.0-add-l10n_br_cte-rebased-multi_schema-refactor branch December 10, 2024 15:23

rvalyi mentioned this pull request Jan 15, 2025

[16.0][l10n_br_fiscal] Oca port 14.0 to 16.0 117911 (changes for MDF-e and CT-e) #3582

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][ADD] l10n_br_cte: add new module #3492

[14.0][ADD] l10n_br_cte: add new module #3492

marcelsavegnago commented Nov 14, 2024

OCA-git-bot commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024 •

edited

Loading

rvalyi commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024

rvalyi left a comment

marcelsavegnago commented Nov 15, 2024 •

edited

Loading

rvalyi commented Nov 15, 2024 •

edited

Loading

mileo Dec 10, 2024

marcelsavegnago Dec 10, 2024

rvalyi Dec 10, 2024 •

edited

Loading

mileo Dec 10, 2024

rvalyi left a comment

marcelsavegnago commented Dec 10, 2024

mileo commented Dec 10, 2024

rvalyi left a comment

OCA-git-bot commented Dec 10, 2024

OCA-git-bot commented Dec 10, 2024

[14.0][ADD] l10n_br_cte: add new module #3492

[14.0][ADD] l10n_br_cte: add new module #3492

Conversation

marcelsavegnago commented Nov 14, 2024

OCA-git-bot commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024 • edited Loading

rvalyi commented Nov 14, 2024

marcelsavegnago commented Nov 14, 2024

rvalyi left a comment

Choose a reason for hiding this comment

marcelsavegnago commented Nov 15, 2024 • edited Loading

rvalyi commented Nov 15, 2024 • edited Loading

mileo Dec 10, 2024

Choose a reason for hiding this comment

marcelsavegnago Dec 10, 2024

Choose a reason for hiding this comment

rvalyi Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

mileo Dec 10, 2024

Choose a reason for hiding this comment

rvalyi left a comment

Choose a reason for hiding this comment

marcelsavegnago commented Dec 10, 2024

mileo commented Dec 10, 2024

rvalyi left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Dec 10, 2024

OCA-git-bot commented Dec 10, 2024

marcelsavegnago commented Nov 14, 2024 •

edited

Loading

marcelsavegnago commented Nov 15, 2024 •

edited

Loading

rvalyi commented Nov 15, 2024 •

edited

Loading

rvalyi Dec 10, 2024 •

edited

Loading