-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] l10n_br_cnpj_search: Migration to 15.0 #3112
Conversation
Currently translated at 89.6% (26 of 29 strings) Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/pt_BR/
…nnecessary use TRY to import a library.
… for the new version of pre-commit.
Currently translated at 89.6% (26 of 29 strings) Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/
Currently translated at 57.8% (37 of 64 strings) Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/pt_BR/
Currently translated at 82.8% (53 of 64 strings) Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/pt_BR/
8cc349a
to
f872152
Compare
@renatonlima quando puder comentar aquele PR: #2635 |
@mileo eu fiz a revisão do PR #2635 e vou acompanhar esse PR de perto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tem que substituir o SavepointCase pelo TransactionCase nos tests poque o SavoipointCase ta deprecated na 15.0 e removido na 16.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- o ultimo commit pode ser removido, nao serve, pois installable; True ja eh o padrao.
- tb eh melhor fazer um squash do commit db0b8c8 dentro do commit de migracao anterior. So eh legal dividir os commits de migracao quando a migracao eh complexa e justifica (como por examplo do l10n_br_account da 12 para a 13).
417ee5e
to
e453e08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
/ocabot merge migration l10n_br_cnpj_search |
Hi @rvalyi. Your command failed:
Ocabot commands
More information
|
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 16edf30. Thanks a lot for contributing to OCA. ❤️ |
l10n_br_cnpj_search: Migration to 15.0