Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] l10n_br_cnpj_search: Migration to 15.0 #3112

Merged
merged 47 commits into from
Jun 11, 2024

Conversation

renatonlima
Copy link
Member

l10n_br_cnpj_search: Migration to 15.0

ODBreno and others added 30 commits May 31, 2024 13:31
Currently translated at 89.6% (26 of 29 strings)

Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search
Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/pt_BR/
Currently translated at 89.6% (26 of 29 strings)

Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search
Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/pt_BR/
CristianoMafraJunior and others added 7 commits May 31, 2024 13:31
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search
Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/
Currently translated at 57.8% (37 of 64 strings)

Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search
Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/pt_BR/
Currently translated at 82.8% (53 of 64 strings)

Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_cnpj_search
Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_cnpj_search/pt_BR/
@mileo
Copy link
Member

mileo commented Jun 6, 2024

@renatonlima quando puder comentar aquele PR: #2635

@renatonlima
Copy link
Member Author

@renatonlima quando puder comentar aquele PR: #2635

@mileo eu fiz a revisão do PR #2635 e vou acompanhar esse PR de perto

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tem que substituir o SavepointCase pelo TransactionCase nos tests poque o SavoipointCase ta deprecated na 15.0 e removido na 16.0.

Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • o ultimo commit pode ser removido, nao serve, pois installable; True ja eh o padrao.
  • tb eh melhor fazer um squash do commit db0b8c8 dentro do commit de migracao anterior. So eh legal dividir os commits de migracao quando a migracao eh complexa e justifica (como por examplo do l10n_br_account da 12 para a 13).

@renatonlima renatonlima force-pushed the 15.0-mig-l10n_br_cnpj_search branch from 417ee5e to e453e08 Compare June 11, 2024 15:32
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@rvalyi
Copy link
Member

rvalyi commented Jun 11, 2024

/ocabot merge migration l10n_br_cnpj_search

@OCA-git-bot
Copy link
Contributor

Hi @rvalyi. Your command failed:

Invalid options for command merge: migration l10n_br_cnpj_search.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@rvalyi
Copy link
Member

rvalyi commented Jun 11, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-3112-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a832e85 into OCA:15.0 Jun 11, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 16edf30. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.