Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][l10n_br_fiscal] fix property migrations #1890

Merged
merged 2 commits into from
Apr 29, 2022
Merged

[12.0][l10n_br_fiscal] fix property migrations #1890

merged 2 commits into from
Apr 29, 2022

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Apr 28, 2022

resolve esse bug #1862 e o mesmo tipo de bug com a migração do campo fiscal_type.
Basicamente no script de pre-migration, o update ainda nao rodou no banco mas os campos Python dos objetos já foram carregados e nisso nao tem mais esses campos icms_origin ou fiscal_type para usar um domain Odoo. Eu usar um SELECT então.

cc @vanderleiromera @renatonlima

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

@rvalyi rvalyi force-pushed the 12-fix-prop-upgrades branch from e2a799f to 1ec1d82 Compare April 28, 2022 22:04
@marcelsavegnago
Copy link
Member

mesmo erro da minha PR

image

@rvalyi
Copy link
Member Author

rvalyi commented Apr 28, 2022

mesmo erro da minha PR

image

sai para la com o erro da sua PR!
quero não ;-)

vanderleiromera
vanderleiromera approved these changes Apr 28, 2022
View reviewed changes
Copy link

@vanderleiromera vanderleiromera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inseto aniquilado @@

@rvalyi
Copy link
Member Author

rvalyi commented Apr 28, 2022 •
edited
Loading

@marcelsavegnago @renatonlima @netosjb eu sugiro de usar esse workaround para destravar o repo ate a OCA tomar uma posiçao ou arrumar uma soluçao para esse QUnitSuite
a5f85da
akretion/maintainer-quality-tools@e46917c
ver tb meu report aqui OCA/maintainer-quality-tools#704

O que vcs acham? Apenas para destravar os PRs travados da 12 mesmo por enquanto...

@rvalyi rvalyi force-pushed the 12-fix-prop-upgrades branch from bb4f8a0 to a5f85da Compare April 28, 2022 23:05
@rvalyi rvalyi force-pushed the 12-fix-prop-upgrades branch from a5f85da to 7e3876a Compare April 29, 2022 00:16
@marcelsavegnago
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1890-by-marcelsavegnago-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cc2f6ae into OCA:12.0 Apr 29, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cd6c5f4. Thanks a lot for contributing to OCA. ❤️

@rvalyi rvalyi mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanderleiromera vanderleiromera vanderleiromera approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

@renatonlima renatonlima renatonlima approved these changes

Assignees
No one assigned
Labels
12.0 approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rvalyi @OCA-git-bot @marcelsavegnago @renatonlima @antoniospneto @vanderleiromera