[14.0][FIX]attachment_preview: get preview for files in db only #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaynnan
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
LGTM. I tested it locally, and it worked as expected.
@PicchiSeba, if possible, please rebase so that is available the runboat so that others can review it.
PicchiSeba
force-pushed
the
14.0-fix-attachment_preview-missing-record
branch
from
244c967
to
06a0843
Compare
|
Hi @kaynnan , thank you for your review. I just rebased :) |
|
This PR has the |
WesleyOliveira98
approved these changes
Jun 27, 2024
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at b315d47. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few cases, when a user uploads files such as PDFs, when the client tries to get the preview, the file may not be saved yet.
This results in the following error
With this check we fetch only the previews of those files we know the id of.