Conversation
Anxo82
force-pushed
the
18.0-add-hr_collective_agreement
branch
from
36dd8d6 to
4ae9a5d
Compare
|
|
||
| code = fields.Char(required=True) | ||
| name = fields.Text(required=True) | ||
| scope_id = fields.Many2one( |
There was a problem hiding this comment.
What is this scope model and field for? A definition and/or explanation in the readme DESCRIPTION, and maybe in the help for this field might be useful.
There was a problem hiding this comment.
Added a help text to the scope_id field and a short explanation of the Scope and Official Publication fields in the README. Thanks
| column2="partner_id", | ||
| string="Partners", | ||
| check_company=True, | ||
| domain="['|', ('company_id', '=', False), ('company_id', '=', company_id)]", |
There was a problem hiding this comment.
Or you might set _check_company_auto = True on the class level, to have this check automatic for all model references that might contain a company_id field.
NL66278
left a comment
NL66278
left a comment
There was a problem hiding this comment.
👍 Thank you for your contribution. Just purge copyright lines from the init files and add some help or explanation and it will be good to go.
Anxo82
force-pushed
the
18.0-add-hr_collective_agreement
branch
from
4ae9a5d to
a93336b
Compare
Anxo82
force-pushed
the
18.0-add-hr_collective_agreement
branch
from
a93336b to
3f34e24
Compare
NL66278
left a comment
NL66278
left a comment
There was a problem hiding this comment.
👍 Actually I am not quite sure whether the domain on the partner_id field is still needed with _check_company_auto, but it will not hurt anyway. Thanks again!
2 participants
@HaraldPanten @Jaimermaccione