Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix 17.0] hr_expense_invoice #274

Closed
wants to merge 2 commits into from
Closed

Conversation

TheCloneMaster
Copy link
Contributor

@TheCloneMaster TheCloneMaster commented Oct 21, 2024

Fixes issue:
#273

If an expense report includes invoices from diferent providers, when posting move the report moves to "paid" and invoices are not reconciled as paid, as it fails to reconcile the lines with the transfer moves.

Use the correct partner, from current expense line from the report, not always the same partner from first expense line

Use the correct partner, from current expense line from the report, not always the same partner from first expense line
@pedrobaeza pedrobaeza added this to the 17.0 milestone Oct 21, 2024
@pedrobaeza
Copy link
Member

Please use proper commit message: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message and respect pre-commit formatting.

@TheCloneMaster TheCloneMaster changed the title Update hr_expense_sheet.py [Fix 17.0] hr_expense_invoice Oct 21, 2024
@TheCloneMaster
Copy link
Contributor Author

Hope it has correct format now
Thanks

@pedrobaeza
Copy link
Member

The commit message and pre-commit stays the same:

imagen

You can't amend it from GitHub. You need to do another edit/PR, or use your computer to pull the branch, amend it, and push again.

The proper commit message is:

[FIX] hr_expense_invoice: Proper partner

If an expense report includes invoices from different providers,
when posting move the report moves to "paid" and invoices are not
reconciled as paid, as it fails to reconcile the lines with the
transfer moves.

Use the correct partner, from current expense line from the report,
not always the same partner from first expense line.

Fixes #273

Fix ruff error on bad binding of "expense" variable on lambda function
@TheCloneMaster
Copy link
Contributor Author

I think I better close this one, and try again with your guidelines!
Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants