Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] hr_expense_advance_clearing #258

Open
wants to merge 89 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] hr_expense_advance_clearing #258

wants to merge 89 commits into from

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Jul 19, 2024 •
edited
Loading

  • Refactor code for support odoo17

kittiu and others added 30 commits July 19, 2024 13:42
@kittiu @Saran440
[12.0][ADD] hr_expense_advance_clearing
1e299d8 
[UPD] Update hr_expense_advance_clearing.pot

[UPD] README.rst
@kittiu @Saran440
[12.0][FIX] hr_expense_advance_clearing
3490106 
Fix install error when there are already some expense in system.

[UPD] README.rst

hr_expense_advance_clearing 12.0.1.0.1
@kittiu @Saran440
[IMP] : black, isort
09127b9
@kittiu @Saran440
[13.0][MIG] hr_expense_advance_clearing
a401a89
@oca-travis @Saran440
[UPD] Update hr_expense_advance_clearing.pot
92e167d
@OCA-git-bot @Saran440
[UPD] README.rst
eb1714c
@chienandalu @Saran440
[FIX] hr_expense_advance_clearing: analytic account visibility
d7a8f0a 
We should prevent setting the analytic account in expenses used as
employees advance. Otherwise, it can lead to errors charging against an
analytic account that later won't be compensated when all is reconcile.
Anyway, the advance is not an expense, but money of the company moving
from one place to another, that later will be used for real expenses
that will be imputed to the corresponding analytic account
@newtratip @Saran440
[13.0][UPD] Add Contributors
7a98c43
@OCA-git-bot @Saran440
hr_expense_advance_clearing 13.0.1.0.1
859026b
@chienandalu @Saran440
[IMP] hr_expense_advance_clearing: hide analytics tags as well
606a640
@OCA-git-bot @Saran440
hr_expense_advance_clearing 13.0.1.1.0
a0f6fb3
@Saran440
[FIX] rename fields residual
2b522c6
@oca-travis @Saran440
[UPD] Update hr_expense_advance_clearing.pot
ecb5ae4
@OCA-git-bot @Saran440
hr_expense_advance_clearing 13.0.1.2.0
f44d808
@Saran440
[14.0][MIG] hr_expense_advance_clearing
5a78f0b
@OCA-git-bot @Saran440
[UPD] README.rst
3a3b025
@Saran440
[FIX] hr_expense_advance_clearing: default_get return advance
7699e43
@oca-travis @Saran440
[UPD] Update hr_expense_advance_clearing.pot
a18d5fe
@OCA-git-bot @Saran440
hr_expense_advance_clearing 14.0.1.0.1
5e69ec9
@kittiu @Saran440
[14.0][IMP] hr_expense_advance_clearing, add invisible fields
b8ba7b5
@OCA-git-bot @Saran440
hr_expense_advance_clearing 14.0.1.0.2
f5c2002
@kittiu @Saran440
[14.0][IMP] hr_expense_advance_clearing, allow predefined clearing pr…
273a204 
…oduct
@oca-travis @Saran440
[UPD] Update hr_expense_advance_clearing.pot
69732fe
@OCA-git-bot @Saran440
[UPD] README.rst
ab0708b
@OCA-git-bot @Saran440
hr_expense_advance_clearing 14.0.1.1.0
4c54e59
@Saran440
[IMP] clearing tab on advance sheet
1754e07
@oca-travis @Saran440
[UPD] Update hr_expense_advance_clearing.pot
aa18e21
@OCA-git-bot @Saran440
hr_expense_advance_clearing 14.0.1.2.0
b0998ec
@kittiu @Saran440
[14.0][IMP] hr_expense_advance_clearing, add invisible fields on tree…
97554cf 
… view
@OCA-git-bot @Saran440
hr_expense_advance_clearing 14.0.1.2.1
57a9880
OCA-git-bot and others added 18 commits July 19, 2024 13:42
@OCA-git-bot @Saran440
hr_expense_advance_clearing 15.0.1.0.1
0636240
@ps-tubtim @Saran440
[15.0][FIX] hr_expense_advance_clearing: zero unit price
6994bae
@OCA-git-bot @Saran440
hr_expense_advance_clearing 15.0.1.1.0
24cd902
@Saran440
[FIX] update readme
98a2062
@Saran440
[FIX] hr_expense_advance_clearing: change field not compute advance
7131bc3
@OCA-git-bot @Saran440
hr_expense_advance_clearing 15.0.1.2.0
3a65f20
@OCA-git-bot @Saran440
[UPD] README.rst
d101994
@mymage @Saran440
Added translation using Weblate (Italian)
b199eef
@mymage @Saran440
Translated using Weblate (Italian)
bc96bcf 
Currently translated at 100.0% (57 of 57 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_clearing
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_clearing/it/
@OCA-git-bot @Saran440
[UPD] README.rst
37b1cd0
@Saran440
[MIG] hr_expense_advance_clearing: Migration to 16.0
ed63af5
@Saran440
[UPD] Update hr_expense_advance_clearing.pot
f3a7768
@weblate @Saran440
Update translation files
26c26d4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_advance_clearing
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_advance_clearing/
@mymage @Saran440
Translated using Weblate (Italian)
7f09b8c 
Currently translated at 100.0% (56 of 56 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_advance_clearing
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_advance_clearing/it/
@Saran440
[FIX] hr_expense_advance_clearing: clear advance partial
c8e60e4
@OCA-git-bot @Saran440
[BOT] post-merge updates
29d0add
@Saran440
[IMP] hr_expense_advance_clearing: pre-commit auto fixes
1f9a613
@Saran440
[MIG] hr_expense_advance_clearing: Migration to 17.0
aeccf7b
@Saran440
Copy link
Member Author

@hongquangminh Please, close your PR #255 and help us to review this please?
Tested on standard flow and it's work.

@Saran440
Copy link
Member Author

/ocabot migration hr_expense_advance_clearing

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 19, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 19, 2024
Open
7 tasks
@hongquangminh
Copy link
Member

@hongquangminh Please, close your PR #255 and help us to review this please?

Tested on standard flow and it's work.

Thanks for inform me. It look fine now. Btw, can I add the vi.po file for translate?

@Saran440
Copy link
Member Author

@hongquangminh yes, you can open new PR to https://github.com/ecosoft-odoo/hr-expense/tree/17.0-mig-hr_expense_advance_clearing

or wait this PR merged and translate by https://translation.odoo-community.org/

@gjlong68
Copy link

when press Return Advance have a error
image

@Saran440
Copy link
Member Author

@gjlong68 Can you please add step to error?
Maybe you can check if the product advance is set to reconcile yet.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 24, 2024
@victoralmau
Copy link
Member

Please cherry-pick #278 to commit history (only related to hr_expense_advance_clearing)

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.