Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] hr_expense_tier_validation #227

Merged
merged 37 commits into from
Feb 26, 2025
Merged

[17.0][MIG] hr_expense_tier_validation #227

merged 37 commits into from
Feb 26, 2025
+1,062 −0

Conversation

WorrapongOngsakul
Copy link
Contributor

No description provided.

@kittiu
Copy link
Member

kittiu commented Mar 15, 2024

Please use module name like this on subject, it is easier to search by others, e.g., hr_expense_tier_validation

@WorrapongOngsakul WorrapongOngsakul changed the title [17.0][MIG] hr expense tier validation [17.0][MIG] hr_expense_tier_validation Mar 15, 2024
@kittiu
Copy link
Member

kittiu commented Mar 19, 2024

@WorrapongOngsakul can you squashed your commit (2 commit into 1 commit).
Please note that, you can also use git commit --amend if you don't want to add more commits.

@WorrapongOngsakul WorrapongOngsakul force-pushed the 17.0-mig-hr_expense_tier_validation branch from 971df3b to d7165f8 Compare March 20, 2024 06:38
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@Saran440 Saran440 removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 23, 2024
@Saran440 Saran440 force-pushed the 17.0-mig-hr_expense_tier_validation branch from 8cd54fe to 5645960 Compare July 23, 2024 03:24
@Saran440
Copy link
Member

Saran440 commented Jul 23, 2024 •
edited
Loading

  • Delete file hr.expense can use core tier validation
  • Fixes test script

Saran440
Saran440 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍

@Saran440
Copy link
Member

/ocabot migration hr_expense_tier_validation

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 23, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 23, 2024
Open
7 tasks
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 24, 2024
@victoralmau
Copy link
Member

Please cherry-pick #278 to commit history (only related to hr_expense_tier_validation)

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 1, 2024
@Saran440 Saran440 mentioned this pull request Feb 26, 2025
Merged
2 tasks
mymage and others added 14 commits February 26, 2025 16:11
@mymage @Saran440
Added translation using Weblate (Italian)
219d85b
@mymage @Saran440
Translated using Weblate (Italian)
91facc2 
Currently translated at 100.0% (18 of 18 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_tier_validation/it/
@OCA-git-bot @Saran440
[UPD] README.rst
5ceb753
@Saran440
[UPD] Update hr_expense_tier_validation.pot
4cd0b4d
@AnutToc @Saran440
[MIG] hr_expense_tier_validation: Migration to 16.0
ba71236
@Saran440
[UPD] Update hr_expense_tier_validation.pot
b8d05b0
@OCA-git-bot @Saran440
[BOT] post-merge updates
31a2eac
@weblate @Saran440
Update translation files
4ed2f75 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/
@mymage @Saran440
Translated using Weblate (Italian)
dde5893 
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
@mymage @Saran440
Translated using Weblate (Italian)
7ea9989 
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
@mymage @Saran440
Translated using Weblate (Italian)
a0f1162 
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
@mymage @Saran440
Translated using Weblate (Italian)
d16c0da 
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
@mymage @Saran440
Translated using Weblate (Italian)
71deb5e 
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
@WorrapongOngsakul @Saran440
[IMP] hr_expense_tier_validation: pre-commit auto fixes
aea2045
@Saran440 Saran440 force-pushed the 17.0-mig-hr_expense_tier_validation branch from 290c2b5 to 41ab6cc Compare February 26, 2025 09:12
@Saran440
Copy link
Member

@Saran440 Saran440 force-pushed the 17.0-mig-hr_expense_tier_validation branch from 41ab6cc to 36a9bba Compare February 26, 2025 09:31
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Saran440
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-227-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 66418eb. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 1175885 into OCA:17.0 Feb 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saran440 Saran440 Saran440 approved these changes

@newtratip newtratip newtratip approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.