[15.0][MIG] hr_expense_substate

[Saran440]

Standard migrate

[Saran440]

/ocabot migration hr_expense_substate

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[bosd]

Thanks for your efforts.
Did a functionally test on runboat. It failed..
Error message (Propably not yours)

Traceback (most recent call last):
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
  File "/opt/odoo/odoo/http.py", line 698, in dispatch
    result = self._call_function(**self.params)
  File "/opt/odoo/odoo/http.py", line 368, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/opt/odoo/odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File "/opt/odoo/odoo/http.py", line 357, in checked_call
    result = self.endpoint(*a, **kw)
  File "/opt/odoo/odoo/http.py", line 921, in __call__
    return self.method(*args, **kw)
  File "/opt/odoo/odoo/http.py", line 546, in response_wrap
    response = f(*args, **kw)
  File "/opt/odoo/addons/web/controllers/main.py", line 1328, in call_button
    action = self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/main.py", line 1316, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 464, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 451, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/mnt/data/odoo-addons-dir/hr_expense_pay_to_vendor/models/hr_expense.py", line 91, in action_sheet_move_create
    res = super().action_sheet_move_create()
  File "/mnt/data/odoo-addons-dir/hr_expense_invoice/models/hr_expense_sheet.py", line 20, in action_sheet_move_create
    move_lines = res[sheet.id].line_ids
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 654, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/opt/odoo/odoo/http.py", line 301, in _handle_exception
    raise exception.with_traceback(None) from new_cause
KeyError: 6

[Saran440]

@bosd Thank you for your review. May be this PR is not up to date of runboat. Can you check again please?

[bosd]

Thanks for this addition.
Was unable to functionally test this.. See review comments.

Can you add unit tests?

[bosd]

Can you migrate this mail template to V15.
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

On runboat I didn't see this mail template being attached to an substate.
propably because the demo data is not correctly loaded.

[Saran440]

it is a bug of module base_substate.
Now i fixed it here OCA/server-ux#735
Can you help review please?

[bosd]

In other modules the substates have moved to the line below on the form view.
Example from account_move_substate I'm working on.

https://github.com/OCA/account-invoicing/pull/1568/files#diff-1947d80641a90451e063090957b86e45ae7bbe8d67d9bea602469e8eab9e6106R8-R16

Can you change this view to keep consistency?

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[bosd]

@Saran440 Can you incorporate the latest changes? (or is it already done) After that, please retrigger runboat creation. Would like to func test it 🙏

[bosd]

I think this line can be deleted. The improved one is already above

[Saran440]

This description for explain this module. I think it okay to use this.

[bosd]

We this module is not proper english :)
The line says the same as the lines above, so it is a duplicate.

[bosd]

@Saran440 Going to review this one now. Can you please attend to my earlier comment.

[Saran440]

@bosd Sorry for very late reply. Can you check again. I think this PR ready to merge.

[bosd]

I've quickly tested this on he runboat. I stil ldon't see the email being set.
http://oca-hr-expense-15-0-pr143-507653dfdee6.runboat.odoo-community.org/web?debug=1#cids=1&menu_id=221&active_id=4&model=hr.expense.sheet&view_type=form&id=7

[bosd]

Not send email because it waiting OCA/server-ux#735

AAh.. So we should attend that PR first.

I'm shy to ask, but could you add that PR as a dependency here in test-requirements.txt?
So we can test the full flow on a runboat here.

[bosd]

@Saran440 Can you add the dependency in the test-requirements.txt So we can test the full flow on a runboat?

[Saran440]

@bosd Add it in test-requirement. I not sure that is correct please recheck.

[bosd]

@bosd Add it in test-requirement. I not sure that is correct please recheck.

Thanks!!
I think it is correctly added.
Have to dig into why tests are failling. (Sadly, I'm really occupied lately).
Are tests ok on your local system?

[Saran440]

Amm, I never use test-requirement. Not sure why it failed.
However, This module I used on production.

[bosd]

It fails, because there is something wrong in the base_substate with the inheritance of mail.thread

[bosd]

@Saran440 can you please force push here?
To see if checks are passing with your newest commit on the base module.

[bosd]

Just functionally tested this one on the runboat. The "verified" email is not being sent.
Is this one still depending on OCA/server-ux#735 ?

[bosd]

@Saran440 I know you spent already a lot of time on this module.
But ideally some added tests would be nice. For example/inspiration see : https://github.com/OCA/purchase-workflow/blob/14.0/purchase_substate/tests/test_purchase_substate.py

[Saran440]

@bosd please wait, I'm doing fixed. and find a way to send message.

[Saran440]

@bosd Now, I think it's work to me (but it depend OCA/server-ux#735)

[bosd]

Now, I think it's work to me (but it depend OCA/server-ux#735)

Can you please add that back to the test-requirements.txt like before, so we can test it here on the runboat.

Then after a cleanup and squash of commits it is approved for me.

[bosd]

oopsie my bad, (Im learning this as well) Appears my suggestion for the name in test-requirements.txt was wrong.
Error has inconsistent name: expected 'odoo15-addon-base-substate', but metadata has 'odoo-addon-base-substate'

[Dranyel-Bosd]

looks so good to me 💯

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[bosd]

Please don't go stale :)
Let's merge the base module and the depending ones.