Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] fieldservice: Search by name. #1270

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

DorianMAG
Copy link

Remove str method in xml search filter_domain

@OCA-git-bot
Copy link
Contributor

Hi @brian10048, @max3903,
some modules you are maintaining are being modified, check this out!

@DorianMAG DorianMAG changed the title [17.0][FIX] Fieldservice: Search by name. [17.0][FIX] fieldservice: Search by name. Nov 27, 2024
Remove str method in xml search filter_domain
@DorianMAG DorianMAG force-pushed the 17.0-fix-fieldservice-search_by_name branch from d96032c to cb36421 Compare November 27, 2024 11:18
@max3903 max3903 added this to the 17.0 milestone Nov 27, 2024
@max3903 max3903 self-assigned this Nov 27, 2024
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if I undestand the syntxa, I thinks it's useless
IMHO ('name', 'ilike', self ) should be enough
could you please give you POV @ilo @max3903 ?
Regards

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @max3903 approve I have no technical comments on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants