-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][ADD] fieldservice_equipment_stock_return: add return order type #1241
base: 17.0
Are you sure you want to change the base?
Conversation
Hi @max3903, @brian10048, @smangukiya, @wolfhall, |
@EdgarRetes Can you test and review? |
Hello @max3903 |
077e64d
to
b17b846
Compare
a991d94
to
f63eb8c
Compare
@EdgarRetes if/when tests are OK, you can re-test. |
Looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test exercising the new code.
Please update readme/USAGE.md to include something along the line of
"""The Return field service order type can be used to create a field service order to dispatch someone to pickup an equipment in its current location. From the order, it is possible to create an incoming stock picking to record the return of the equipment."""
f63eb8c
to
755ae2b
Compare
755ae2b
to
8dfd9eb
Compare
ce0d3b7
to
b440329
Compare
fieldservice_equipment_stock_return/static/description/icon.png
Outdated
Show resolved
Hide resolved
b440329
to
f7df6d1
Compare
Hello @max3903, Thanks a lot |
@imlopes LGTM Can you update the icon? https://github.com/OCA/field-service/blob/17.0/fieldservice/static/description/icon.png |
This PR has the |
Initially this PR was adding a feature on the current module
fieldservice_equipment_stock
.It seems more appropriate to create a separate module adding the
return
option on the equipments.