Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] fieldservice_sale_recurring #1149

Open
wants to merge 63 commits into
base: 16.0
Choose a base branch
from
Open

[16.0] [MIG] fieldservice_sale_recurring #1149

wants to merge 63 commits into from

Conversation

brian10048
Copy link
Contributor

No description provided.

max3903 and others added 30 commits December 13, 2023 10:21
@max3903 @brian10048
[ADD] fieldservice_sale_recurring
7476ca1
@max3903 @brian10048
Update fieldservice_sale_recurring/models/product_template.py
f72ae51 
Co-Authored-By: brian10048 <[email protected]>
@OCA-git-bot @brian10048
[UPD] README.rst
32dc5c0
@max3903 @brian10048
[FIX] fieldservice_sale_recurring
d34bfe9
@oca-travis @brian10048
[UPD] Update fieldservice_sale_recurring.pot
751b0eb
@marylla @brian10048
Added translation using Weblate (German)
5789849
@marylla @brian10048
Translated using Weblate (German)
f3a2bb0 
Currently translated at 60.0% (12 of 20 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/de/
@max3903 @brian10048
[IMP] fieldservice_sale_recurring
e9053c2
@oca-travis @brian10048
[UPD] Update fieldservice_sale_recurring.pot
2665ea5
@oca-transbot @brian10048
Update translation files
359054d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/
@brian10048
Added translation using Weblate (Spanish (Chile))
dd7b412
@brian10048
Translated using Weblate (Spanish (Chile))
7e4042e 
Currently translated at 100.0% (21 of 21 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/es_CL/
@brian10048
[FIX] fieldservice_sale_recurring
0bae2b0 
- Was not calling super properly and FSM orders on the sale line that were not recurring orders were not being created.
- Delete unused computed field.
@brian10048
[FIX] fieldservice_sale_recurring: Product view
217567a
@OCA-git-bot @brian10048
fieldservice_sale_recurring 12.0.1.1.0
c5b66e3
@marcelsavegnago @brian10048
Added translation using Weblate (Portuguese (Brazil))
9520932
@max3903 @brian10048
[ADD] Spanish (es) translation
4a39013
@marcelsavegnago @brian10048
Translated using Weblate (Portuguese (Brazil))
2552e7b 
Currently translated at 76.2% (16 of 21 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/pt_BR/
@marcelsavegnago @brian10048
Translated using Weblate (Portuguese (Brazil))
b335acf 
Currently translated at 76.2% (16 of 21 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/pt_BR/
@fcolus @brian10048
Translated using Weblate (Portuguese (Brazil))
5465d13 
Currently translated at 100.0% (21 of 21 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/pt_BR/
@fcolus @brian10048
Translated using Weblate (Portuguese (Brazil))
c4a5540 
Currently translated at 100.0% (21 of 21 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/pt_BR/
@brian10048
[IMP] fieldservice_sale_recurring: Add test
3502493
@OCA-git-bot @brian10048
fieldservice_sale_recurring 12.0.1.2.0
f4b82e9
@oca-transbot @brian10048
Update translation files
80ab07f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/
@mymage @brian10048
Added translation using Weblate (Italian)
504590a
@mymage @brian10048
Translated using Weblate (Italian)
1bd49a7 
Currently translated at 100.0% (21 of 21 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/it/
@hparfr @brian10048
[IMP] fieldservice_sale_recurring : black, isort, prettier
c54b869
@brian10048
[MIG] fieldservice_sale_recurring: Migration to 13.0
49aafbe
@hparfr @brian10048
[MIG] fieldservice_sale_recurring: Migration to 14.0
c8e8361 
implement OCA#735

Prefer fsm_order_template from product (directly)
else from product.fsm_recurring_template

Adapt product's view
@hparfr @brian10048
[FIX] fieldservice_sale_recurring fix test
e229555
dreispt and others added 12 commits December 13, 2023 10:21
@dreispt @brian10048
[REF] fieldservice_sale_recurring: pre-commit fixes
90ed757
@brian10048
[UPD] Update fieldservice_sale_recurring.pot
e4c3065
@OCA-git-bot @brian10048
[BOT] post-merge updates
4e234a2
@weblate @brian10048
Update translation files
029e19f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/
@Ivorra78 @brian10048
Translated using Weblate (Spanish)
c1a1f17 
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/es/
@mymage @brian10048
Translated using Weblate (Italian)
ce73a1e 
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/it/
@mymage @brian10048
Translated using Weblate (Italian)
1c2fee2 
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/it/
@ibuioli @brian10048
Translated using Weblate (Spanish (Argentina))
1ccc307 
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/es_AR/
@mourad-ehm @brian10048
[FIX][14.0]: fieldservice_sale_recurring: recurring order validation …
d70e3b8 
…generate wrong fsm_order (ex: Assigned To not set, start date wrong, recuring info not set, ...)
@paradoxxxzero @brian10048
[FIX][14.0] fieldservice_sale_recurring: make link between invoice an…
36098ba 
…d fsm order for recurring order
@brian10048
[FIX] fieldservice_sale_*
98deb29 
Do not copy FSM Order or FSM Recurring Orders on sale order line
@OCA-git-bot @brian10048
[BOT] post-merge updates
0703d24
@brian10048 brian10048 added this to the 16.0 milestone Dec 13, 2023
@brian10048 brian10048 force-pushed the 16.0-mig-fieldservice_sale_recurring branch from 92d493f to 047918b Compare December 13, 2023 15:36
@brian10048 brian10048 self-assigned this Dec 13, 2023
@SMaciasOSI SMaciasOSI mentioned this pull request Jan 9, 2024
Closed
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 14, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 8, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024
@github-actions github-actions bot closed this Oct 13, 2024
@dreispt dreispt reopened this Oct 18, 2024
@dreispt dreispt added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Oct 18, 2024
ivantodorovich
ivantodorovich approved these changes Nov 21, 2024
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking comment, not blocking

fieldservice_sale_recurring/models/sale_order.py

def action_view_fsm_recurring(self):
fsm_recurrings = self.mapped("fsm_recurring_ids")
action = self.env.ref("fieldservice_recurring.action_fsm_recurring").read()[0]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
action = self.env.ref("fieldservice_recurring.action_fsm_recurring").read()[0]
action = self.env["ir.actions.act_window"]._for_xml_id("fieldservice_recurring.action_fsm_recurring")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@dreispt dreispt dreispt approved these changes

Assignees

@brian10048 brian10048

Labels
approved no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.