-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] event_sale_session: Recovery unconfirmed quantity event #373
Open
carolinafernandez-tecnativa
wants to merge
1
commit into
OCA:16.0
Choose a base branch
from
Tecnativa:16.0-imp-event_sale_session-recovery-button
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
# Copyright 2017 Tecnativa - David Vidal | ||
# Copyright 2022 Moka Tourisme (https://www.mokatourisme.fr). | ||
# Copyright 2024 Tecnativa - Carolina Fernandez | ||
# @author Iván Todorovich <[email protected]> | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl-3.0). | ||
|
||
|
@@ -36,7 +37,9 @@ def setUpClass(cls): | |
|
||
def test_sale_session(self): | ||
"""Sell an event with session""" | ||
self.assertEqual(self.session.unconfirmed_qty, 5) | ||
self.order.action_confirm() | ||
self.assertEqual(self.session.unconfirmed_qty, 0) | ||
regs = self.env["event.registration"].search( | ||
[("sale_order_id", "=", self.order.id)] | ||
) | ||
|
@@ -54,22 +57,6 @@ def test_sale_session(self): | |
orders = self.env["sale.order"].search(action["domain"]) | ||
self.assertIn(self.order, orders) | ||
|
||
def test_sale_order_line_session_onchange_autocomplete(self): | ||
"""Test that session is automatically filled and or unset on form""" | ||
form = Form(self.order) | ||
line = form.order_line.new() | ||
line.product_id = self.product | ||
# Case 1: The event is a session event, but has multiple sessions | ||
line.event_id = self.event | ||
self.assertFalse(line.event_session_id) | ||
# Case 2: The event is a session event with only 1 session | ||
(self.event.session_ids - self.session).active = False | ||
line.event_id = self.event | ||
self.assertEqual(line.event_session_id, self.session) | ||
# Case 3: The event is not a session event, session should be unset | ||
line.event_id = self.env.ref("event.event_0") | ||
self.assertFalse(line.event_session_id) | ||
|
||
def test_sale_order_event_configurator_onchange_autocomplete(self): | ||
"""Test that session is automatically filled and or unset on wizard""" | ||
wizard = self.env["event.event.configurator"].create( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing this whole test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Onchange is only applied when you are in form view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I still don't understand the reason to remove it 😓 are you facing an issue with this test while implementing the new feature?