[14.0][MIG] account_invoice_import #387

alexis-via · 2021-05-25T23:13:42Z

No description provided.

FIX raise error when we don't identify a partner Update README

…+ instructions OCR

Rename test/pdf/ to test/invoices/ to host XML invoices too

… total untaxed (depends on invoice layout)

PEP8 stuff

PEP8 fix

…invoice_zugferd (see README.rst for more info) Move the ZUGFeRD/CII-specific code of account_invoice_import to account_invoice_import_zugferd

Disable test of invoice2data, because this lib is difficult to install

Add support for UBL refunds If you have an UBL refund that I could use to test, please contact me !

Convert YAML test to unittest

…edicated module account_invoice_import_invoice2data Update README.rst and headers to latest OCA conventions.

Better key names in the parsed_inv dict parsed_inv doesn't need to be JSON serializable anymore (small drawback: the invoice is parsed a second time on the second step... but the second step is rarely used)

Move code from account_invoice_import_invoice2data to account_invoice_import

Update REAME and some interface strings about UBL being an ISO standard Small code changes

…to it.

…voice dict, cleaner organisation) Code refactoring: move code in base_business_document_import, factorise code for tax matching (it was duplicated in UBL and ZUGFeRD) Now support PDF with embedded UBL XML file Enable unittests on account_invoice_import_ubl More absolute xpath in account_invoice_import_ubl instead of relative xpath WARNING: these are big changes, I may have broken a few details

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Add unitests in base_business_document_import Small code enhancements/simplifications

Code cleanup/minor changes

Add support for partner creation

alexis-via · 2021-05-25T23:16:05Z

#242

rconjour

LGTM - but maybe link in the description to the example of the mass import bash script.

StefanRijnhart · 2021-05-26T08:27:27Z

account_invoice_import/wizard/account_invoice_import.py

+        # nothing when there is no attachment or when the attachment
+        # fails to import or when the invoice is already created
+        # So, for the moment, we leave it like that...
+        # If you have a better idea, please suggest!


I've implemented the obvious solution here: akretion#4, letting this model inherit from mail.thread, and it works. Maybe you have considered it before, and there may be good reasons not to use it that I've missed?

Thanks for taking it! I see now that I did not remove this comment in the proposed PR. Can you squash that in somewhere?

And a rebase while you are at it, to squash out the merge commit from my intermediate PR

PieterPaulussen

LGTM

fshah-initos

LGTM

alexis-via · 2021-05-31T20:14:49Z

@rconjour I added a note about it via USAGE.rst

mylbco · 2021-06-01T12:16:55Z

I see the PR is approved, can it be merged @StefanRijnhart ?

StefanRijnhart · 2021-06-01T12:28:34Z

@mylbco a merge commit still needs to be squashed out.

StefanRijnhart · 2021-06-02T09:58:50Z

/ocabot merge nobump

OCA-git-bot · 2021-06-02T09:58:59Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-387-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot · 2021-06-02T10:25:25Z

Congratulations, your PR was merged at 9a06de1. Thanks a lot for contributing to OCA. ❤️

Signed-off-by StefanRijnhart

alexis-via and others added 30 commits March 5, 2021 15:07

Rename module from account_invoice_pdf_import to account_invoice_import

22fba80

FIX raise error when we don't identify a partner Update README

Update FR translation

83429c5

Add instructions to use my PPA for poppler-utils on Ubuntu 14.04 LTS …

06800a0

…+ instructions OCR

Add support for direct import of XML files (YAML test provided)

3b068f8

Rename test/pdf/ to test/invoices/ to host XML invoices too

Sometimes, it's easier to extract the total tax amount instead of the…

a5b822f

… total untaxed (depends on invoice layout)

Add an explaination about date parsing in invoice2data

cb80603

Add optional support for start/end dates

f9f0683

Adapt to latest changes in invoice2data

ba54e80

PEP8 stuff

Only change name_get of invoice for our use-case, not everywhere

30b9b32

Update README with latest changes in invoice2data lib

85ecf4d

Add support for partner_email to match partners

6c465d0

PEP8 fix

Update installation procedure.

7a76552

Add modules base_zugferd, account_invoice_import_zugferd and account_…

e45b32b

…invoice_zugferd (see README.rst for more info) Move the ZUGFeRD/CII-specific code of account_invoice_import to account_invoice_import_zugferd

Log raw result of invoice2data (before we make modifications)

2b68edb

Disable test of invoice2data, because this lib is difficult to install

Fix error in README spotted by Roel Adriaans

105bd51

Add module account_invoice_import_ubl

cbd21e3

Add support for UBL refunds If you have an UBL refund that I could use to test, please contact me !

Use base_vat_sanitized

a8a5569

Convert YAML test to unittest

Add support for import of e-fff invoices (Belgian standard)

85f6e5f

Add support for local invoice template for invoice2data, see README

4e5d2df

Small usability improvement

82fdd78

Checks that the directory really exists

337a60f

Extract regular PDF invoice import from account_invoice_import to a d…

95e5d3d

…edicated module account_invoice_import_invoice2data Update README.rst and headers to latest OCA conventions.

Adapt code to plug the module 'ovh_supplier_invoice'

1d4c1e5

Better key names in the parsed_inv dict parsed_inv doesn't need to be JSON serializable anymore (small drawback: the invoice is parsed a second time on the second step... but the second step is rarely used)

Fix product matching

b0c8091

Move code from account_invoice_import_invoice2data to account_invoice_import

FIX PEP8 and account_invoice_import_invoice2data unittests

e08bc84

Update REAME and some interface strings about UBL being an ISO standard Small code changes

Add module base_business_document_import and start to move some code …

be77512

…to it.

Add module base_ubl (common methods to generate and parse UBL files)

0556627

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Add module base_phone_business_document_import

4cbd76d

Add unitests in base_business_document_import Small code enhancements/simplifications

Add a unittest on _match_uom

3075428

Code cleanup/minor changes

yvaucher and others added 6 commits March 5, 2021 15:07

Restore dashboard button overwrite

c5306f4

[RM] invoice line doesn't exist on V13

23027b2

[FIX] account_invoice_import: fix headers

81c25ae

[FIX] account_invoice_import: Reduce method complexity.

2bec1a9

[FIX] account_invoice_import. Do not shadow config module with variable.

8082bb6

[MIG] account_invoice_import to v14

0ece0d7

Add support for partner creation

rconjour suggested changes May 26, 2021

View reviewed changes

[FIX] account_invoice_import: mail gateway exception

4a9125a

StefanRijnhart reviewed May 26, 2021

View reviewed changes

PieterPaulussen approved these changes May 26, 2021

View reviewed changes

fshah-initos approved these changes May 31, 2021

View reviewed changes

alexis-via force-pushed the 14-mig-account_invoice_import branch from 8b01db7 to a1de6ab Compare May 31, 2021 21:04

rconjour approved these changes Jun 1, 2021

View reviewed changes

OCA-git-bot added the approved label Jun 1, 2021

account_invoice_import: Add USAGE.rst

3b62bd2

alexis-via force-pushed the 14-mig-account_invoice_import branch from a1de6ab to 3b62bd2 Compare June 1, 2021 14:52

StefanRijnhart approved these changes Jun 2, 2021

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jun 2, 2021

OCA-git-bot merged commit 4e506a5 into OCA:14.0 Jun 2, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 2, 2021

StefanRijnhart mentioned this pull request Jun 2, 2021

Migration to version 14.0 #242

Open

36 tasks

dsolanki-initos pushed a commit to initOS/edi that referenced this pull request Jun 10, 2021

Merge PR OCA#387 into 14.0

f2db76f

Signed-off-by StefanRijnhart

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] account_invoice_import #387

[14.0][MIG] account_invoice_import #387

alexis-via commented May 25, 2021

alexis-via commented May 25, 2021

rconjour left a comment

StefanRijnhart May 26, 2021

alexis-via May 31, 2021

StefanRijnhart May 31, 2021

StefanRijnhart Jun 1, 2021

PieterPaulussen left a comment

fshah-initos left a comment

alexis-via commented May 31, 2021

mylbco commented Jun 1, 2021

StefanRijnhart commented Jun 1, 2021

StefanRijnhart commented Jun 2, 2021

OCA-git-bot commented Jun 2, 2021

OCA-git-bot commented Jun 2, 2021

[14.0][MIG] account_invoice_import #387

[14.0][MIG] account_invoice_import #387

Conversation

alexis-via commented May 25, 2021

alexis-via commented May 25, 2021

rconjour left a comment

Choose a reason for hiding this comment

StefanRijnhart May 26, 2021

Choose a reason for hiding this comment

alexis-via May 31, 2021

Choose a reason for hiding this comment

StefanRijnhart May 31, 2021

Choose a reason for hiding this comment

StefanRijnhart Jun 1, 2021

Choose a reason for hiding this comment

PieterPaulussen left a comment

Choose a reason for hiding this comment

fshah-initos left a comment

Choose a reason for hiding this comment

alexis-via commented May 31, 2021

mylbco commented Jun 1, 2021

StefanRijnhart commented Jun 1, 2021

StefanRijnhart commented Jun 2, 2021

OCA-git-bot commented Jun 2, 2021

OCA-git-bot commented Jun 2, 2021