Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] edi_sale_ubl_oca #1090

Open
wants to merge 37 commits into
base: 14.0
Choose a base branch
from
Open

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Dec 4, 2024

Replaces #1024
Includes a refactoring based on the division of input and output as done for the base sale module #1075

@simahawk
Copy link
Contributor Author

simahawk commented Dec 6, 2024

TODO on v16 the confirm flag was added on #839 but it contains a bug that I fixed on 08042de (#1090)

Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of "TODO" comments in this PR.
Not sure if you wanted to keep them to handle later on purpose, or if you wanted to take care of them here and forgot.

lines = lines.with_context(edi_sale_skip_state_update=True)
self._handle_order_state(order, lines=lines)

# TODO: what to do?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO? What todo? 🥷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants