-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] edi_sale_ubl_oca #1090
base: 14.0
Are you sure you want to change the base?
Conversation
086f9f9
to
6672496
Compare
TODO on v16 the confirm flag was added on #839 but it contains a bug that I fixed on |
c1cf99f
to
f66dc81
Compare
db56210
to
914e44d
Compare
The Form class is just too dumb. If a field is not there it's broken and if you pass a view for a main record you cannot pass any for the x2m fields which makes it impossible to use for general purpose.
Additionally, avoid recomputing states for all lines when we know which lines have changed.
Several lines' state make the order not satisfied.
Allows to confirm order immediately.
This was supported in early un-merged version of the module. Let's be kind w/ existing configurations ;)
914e44d
to
d0bb156
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of "TODO" comments in this PR.
Not sure if you wanted to keep them to handle later on purpose, or if you wanted to take care of them here and forgot.
lines = lines.with_context(edi_sale_skip_state_update=True) | ||
self._handle_order_state(order, lines=lines) | ||
|
||
# TODO: what to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO? What todo? 🥷
Replaces #1024
Includes a refactoring based on the division of input and output as done for the base sale module #1075