[16.0] base_wamas_ubl: run lib tests #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jbaudoux
commented
Nov 16, 2024
•
jbaudoux
commented
- Add missing freezetime
- Fix html escaping
- Move lib tests to lib (some tests were inside the lib but not run by the CI, some other pure lib tests were inside the module)
- Run all lib tests as module unittests
jbaudoux
force-pushed
the
16-fix-wamas-lib-tests
branch
3 times, most recently
from
2c98cbf to
a9ffd7e
Compare
|
ping @cyrilmanuel @santostelmo @simahawk |
|
@simahawk Can you review and merge this if good for you? |
simahawk
reviewed
Dec 6, 2024
| @@ -60,6 +62,7 @@ def dict2wamas(dict_input, msg_type): | |||
| return wamas | |||
|
|
|||
|
|
|||
| @freeze_time("2024-02-11 22:14:22") | |||
There was a problem hiding this comment.
That's the datetime in the xml, so that the test succeeds
jbaudoux
force-pushed
the
16-fix-wamas-lib-tests
branch
from
a9ffd7e to
8e6280a
Compare
|
rebased |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 811254f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.