Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_invoice_import: Migration to 16.0 #1064

Open
wants to merge 126 commits into
base: 16.0
Choose a base branch
from

Conversation

V3st1g3
Copy link

@V3st1g3 V3st1g3 commented Nov 8, 2024

No description provided.

@V3st1g3 V3st1g3 force-pushed the 16.0-mig-account_invoice_import branch 2 times, most recently from a8f10a7 to 2fd8464 Compare November 8, 2024 15:14
@V3st1g3 V3st1g3 marked this pull request as draft November 8, 2024 15:21
@V3st1g3 V3st1g3 force-pushed the 16.0-mig-account_invoice_import branch 2 times, most recently from 3253566 to cb21c5e Compare November 18, 2024 14:43
@V3st1g3 V3st1g3 marked this pull request as ready for review November 18, 2024 14:46
@V3st1g3
Copy link
Author

V3st1g3 commented Nov 26, 2024

@bosd @simahawk @njeudy

Hi!
I managed to get the tests working.
Do you have any advice to improve code coverage?

@V3st1g3 V3st1g3 force-pushed the 16.0-mig-account_invoice_import branch from cb21c5e to 1d6a195 Compare November 27, 2024 14:52
@V3st1g3 V3st1g3 force-pushed the 16.0-mig-account_invoice_import branch 5 times, most recently from b4e2881 to 604ed56 Compare December 5, 2024 13:05
@V3st1g3
Copy link
Author

V3st1g3 commented Dec 5, 2024

I also migrated account_invoice_import_invoice2data to expand code coverage.

@bosd
Copy link
Contributor

bosd commented Dec 11, 2024

@V3st1g3 Thanks for your work on this.
It's better practive to have one pr per module.
Can you separate the account_invoice_import_invoice2data in a separate pr?

FYI I'm working on a big refactor of the invoice2data library.
Improved code, tests. Updated googlevision to the latest API and AI support.
As well as a new default backend, Which will drop the requirement on poppler. So the library can be installed with a simple pip install.

@alexis-via is to my knowledge working on refactoring the account_invoice_import. Maybe you can combine the efforts to get the new functions and simplifications of the code in here.

Yvesldff and others added 26 commits December 11, 2024 16:17
Currently translated at 94.3% (100 of 106 strings)

Translation: edi-14.0/edi-14.0-account_invoice_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_import/fr/
Currently translated at 96.4% (136 of 141 strings)

Translation: edi-14.0/edi-14.0-account_invoice_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_import/nl/
* do not spoil emails
* message_id is enough to find the msg in Odoo
* no need to be so verbose on where it happened since the logger name is precise
You can now set a specific journal, either via the
account.invoice.import.config or by the pivot dict.
Fix setting invoice_date_due via pivot dict.
Improve multi-company handling in tests.
Add test for setting journal via pivot dict.
Add more checks in test.
Implement what is described in issue OCA#610:
- account_invoice_import_simple_pdf and account_invoice_import_invoice2data can now be use
d together
- when importing an invoice for an unknown partner, it creates an empty invoice with PDF a
s attachment
- when importing an invoice via mail gateway and the from email is set
on a partner that doesn't have any import config, create a supplier
invoice with PDF as attachment and with that partner
- when importing an invoice via mail gateway and the from email is set
on a partner that has a single-line import config, create a supplier
invoice with PDF as attachment, that partner and 1 invoice line with price_unit=0.
FIX import of XML files via mail gateway
FIX attachment number in logs
Currently translated at 94.3% (100 of 106 strings)

Translation: edi-14.0/edi-14.0-account_invoice_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_import/fr/
* line notes

* section headers

* narration fields
Currently translated at 93.1% (135 of 145 strings)

Translation: edi-14.0/edi-14.0-account_invoice_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_import/nl/
The method get_invoice_line_account() was removed from the "account"
module in odoo v13. So we now use the underlying method get_product_accounts()
Fixes bug OCA#572
Currently translated at 100.0% (145 of 145 strings)

Translation: edi-14.0/edi-14.0-account_invoice_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_import/fr/
In the supplier invoice tree view, when the user clicks on the "Upload"
button at the top of the tree view, he now uses the OCA invoice import
wizard instead of the native feature from the 'account' module.
Currently translated at 100.0% (145 of 145 strings)

Translation: edi-14.0/edi-14.0-account_invoice_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_import/es/
Add support for discount on lines in the multi-line create scenario
@V3st1g3 V3st1g3 force-pushed the 16.0-mig-account_invoice_import branch from 604ed56 to b951da2 Compare December 11, 2024 15:40
@V3st1g3 V3st1g3 force-pushed the 16.0-mig-account_invoice_import branch from b951da2 to e30448a Compare December 11, 2024 15:44
@V3st1g3
Copy link
Author

V3st1g3 commented Dec 11, 2024

@bosd
It's done, the PR is here: #1095

Thanks for your reply, I'll look into it when I have time. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.