[16.0][IMP] base_wamas_ubl PromiseDeliveryPeriod #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santostelmo
changed the title
santostelmo
force-pushed
the
16.0-imp-base_wamas_ubl_PromiseDeliveryPeriod
branch
from
aebecbd to
37aa086
Compare
santostelmo
force-pushed
the
16.0-imp-base_wamas_ubl_PromiseDeliveryPeriod
branch
from
37aa086 to
9a311d7
Compare
santostelmo
force-pushed
the
16.0-imp-base_wamas_ubl_PromiseDeliveryPeriod
branch
2 times, most recently
from
68df30d to
d309892
Compare
jbaudoux
reviewed
Sep 12, 2024
Comment on lines
68
to
69
| <cbc:EndDate>2023-05-01</cbc:EndDate> | ||
| <cbc:EndTime>14:00:00</cbc:EndTime> |
There was a problem hiding this comment.
it's better if you use a different date & time in the test in Promise & Estimated otherwise you don't test the right one is going in the right place
There was a problem hiding this comment.
I adapted the test with distinct Promise & Estimated dates
santostelmo
force-pushed
the
16.0-imp-base_wamas_ubl_PromiseDeliveryPeriod
branch
from
d309892 to
90297de
Compare
|
/ocabot merge minor |
|
Sorry @jbaudoux you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
@simahawk This one can be merged :) |
cyrilmanuel
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.