[16.0][FIX] dms_field: Test compatibility #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to avoid applying a template except when testing functionality with dms_field* modules to avoid the error that a directory with the same name already exists (example: create partner). Related to OCA#378
victoralmau
force-pushed
the
16.0-fix-dms_field-compatibility
branch
from
1388109
to
1df6f0b
Compare
CarlosRoca13
approved these changes
Nov 29, 2024
|
Shouldn't the dependent modules inherit from a base test in dms_field? |
|
I have thought about it, but the base test of dms_field would have only the context key set, I think the cost/benefit of having it is not significant. |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 58fa65b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test compatibility
We need to avoid applying a template except when testing functionality with
dms_field*modules to avoid the error that a directory with the same name already exists (example: create partner).Related to #378
Please @pedrobaeza and @CarlosRoca13 can you review it?
@Tecnativa