[16.0][ADD] account_dms_field: New module #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agent-z28
force-pushed
the
16.0-account_dms_field-add-module
branch
2 times, most recently
from
db0cc4c
to
a403e98
Compare
victoralmau
suggested changes
Oct 1, 2024
victoralmau
suggested changes
Oct 2, 2024
Comment on lines
7
to
14
| def _create_dms_directory(self): | ||
| """New method to define the directory automatically in demo data avoiding | ||
| error if it already exists.""" | ||
| self.ensure_one() | ||
| if not self.dms_directory_ids: | ||
| self.with_context( | ||
| res_model=self._name, res_id=self.id | ||
| ).create_dms_directory() |
There was a problem hiding this comment.
Suggested change
| def _create_dms_directory(self): | |
| """New method to define the directory automatically in demo data avoiding | |
| error if it already exists.""" | |
| self.ensure_one() | |
| if not self.dms_directory_ids: | |
| self.with_context( | |
| res_model=self._name, res_id=self.id | |
| ).create_dms_directory() |
Comment on lines
19
to
21
| <function model="dms.field.template" name="_create_dms_directory"> | ||
| <value eval="[ref('field_template_account')]" /> | ||
| </function> |
There was a problem hiding this comment.
Suggested change
| <function model="dms.field.template" name="_create_dms_directory"> | |
| <value eval="[ref('field_template_account')]" /> | |
| </function> |
|
@bizzappdev please review |
agent-z28
force-pushed
the
16.0-account_dms_field-add-module
branch
2 times, most recently
from
6cf41e2
to
42d3cb3
Compare
fix author and correct Readme
agent-z28
force-pushed
the
16.0-account_dms_field-add-module
branch
from
42d3cb3
to
0d48aef
Compare
victoralmau
approved these changes
Oct 16, 2024
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at b536f8a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module adds "account_dms_field"