Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] dms_storage #182

Merged
merged 2 commits into from
Apr 22, 2024
Merged

[ADD] dms_storage #182

merged 2 commits into from
Apr 22, 2024

Conversation

etobella
Copy link
Member

Allows to storage DMS Files on external storages.
TO DO:

  • Update the external directory when changing the drectory from DMS

@marcelsavegnago
Copy link
Member

ping @augustodinizl

_inherit = "dms.storage"

save_type = fields.Selection(
selection_add=[("storage", "Storage")], ondelete={"storage": "cascade"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really necessary? With this approach, it could not be used as an attachment type storage actually.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the idea is to store files on a different place. If you use attachment you will store it on you attachment system. With storage you use the functionality of storage in order to store it somewhere different

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can setup the attachments to be stored on a storage backend, so it doesn't seem to restrict any functionality.

@elvise
Copy link

elvise commented Aug 5, 2022

@etobella really great PR!
Do you have a plan to finish it ?

@etobella
Copy link
Member Author

etobella commented Aug 5, 2022

Well, it was something I did on a sprint code. If you are imterested you can finish it 😉

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 4, 2022
@github-actions github-actions bot closed this Jan 8, 2023
@etobella etobella reopened this Oct 1, 2023
@github-actions github-actions bot closed this Nov 5, 2023
@pedrobaeza pedrobaeza reopened this Nov 5, 2023
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 5, 2023
@len-foss len-foss mentioned this pull request Dec 13, 2023
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 14, 2024
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 18, 2024
@pedrobaeza
Copy link
Member

@etobella can you rebase and fix pre-commit and let's merge this for not losing it, being a new module, it doesn't hurt.

@etobella etobella force-pushed the 14.0-add-dms_storage branch from 66e848e to 384c84c Compare April 21, 2024 20:10
@pedrobaeza pedrobaeza added this to the 14.0 milestone Apr 22, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-182-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ed39c0f into OCA:14.0 Apr 22, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e541909. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants