-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] dms_storage #182
[ADD] dms_storage #182
Conversation
ping @augustodinizl |
_inherit = "dms.storage" | ||
|
||
save_type = fields.Selection( | ||
selection_add=[("storage", "Storage")], ondelete={"storage": "cascade"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really necessary? With this approach, it could not be used as an attachment type storage actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the idea is to store files on a different place. If you use attachment you will store it on you attachment system. With storage you use the functionality of storage in order to store it somewhere different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can setup the attachments to be stored on a storage backend, so it doesn't seem to restrict any functionality.
@etobella really great PR! |
Well, it was something I did on a sprint code. If you are imterested you can finish it 😉 |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@etobella can you rebase and fix pre-commit and let's merge this for not losing it, being a new module, it doesn't hurt. |
66e848e
to
384c84c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at e541909. Thanks a lot for contributing to OCA. ❤️ |
Allows to storage DMS Files on external storages.
TO DO: