[FIX] [16.0] delivery_auto_refresh: Allow override carrier from wizard when changing partner #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbaudoux why you don't want to override carrier when changing partner? I'm missing something, or you do this to cover some case? |
jbaudoux
reviewed
Dec 5, 2024
…hanges on the order
Shide
force-pushed
the
16.0-auto_update_delivery_carrier-delivery_auto_refresh
branch
from
5d21a05 to
bdff1b3
Compare
|
@jbaudoux done as I think you prefer it. Note that sale_order_carrier_auto_assign on v17 has not been migrated following your Migration notes (function has not been renamed) and may need extra work when this change goes to v17 on a migration (I don't think I migrate this module because we are skipping v17 version) |
yajo
approved these changes
Dec 10, 2024
simahawk
approved these changes
Dec 10, 2024
jbaudoux
approved these changes
Dec 10, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at c266410. Thanks a lot for contributing to OCA. ❤️ |
Shide
deleted the
16.0-auto_update_delivery_carrier-delivery_auto_refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always overrides the carrier when partner or delivery partner changes
closes #873
MT-6943 @moduon @rafaelbn @Gelojr @fcvalgar @jbaudoux @simahawk please review if you want :)