[14.0] [ADD] delivery_roulier_picking_batch #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradoxxxzero
force-pushed
the
14.0-add-delivery_roulier_picking_batch
branch
2 times, most recently
from
6813351 to
1c2e92d
Compare
Comment on lines
+34
to
+45
| for package in packages: | ||
| package_pickings = ( | ||
| self.env["stock.move.line"] | ||
| .search( | ||
| [ | ||
| "|", | ||
| ("result_package_id", "=", package.id), | ||
| ("package_id", "=", package.id), | ||
| ] | ||
| ) | ||
| .mapped("picking_id") | ||
| ) |
There was a problem hiding this comment.
We can make it simplier.
We should just check that all picking of the batch have the same delivery address
There was a problem hiding this comment.
I'd rather work at package level since it's them that will be sent and you may want to send 2 packages from different pickings to different addresses.
There was a problem hiding this comment.
In a functional point of view. When you use the batch delivery carrier you want to prepare all the picking for the same address, if user can mix, it will be a nightmare ;).
I am in favors of forcing to set a partner_id on the stock.picking.batch so it will be more understandable for the customer
paradoxxxzero
force-pushed
the
14.0-add-delivery_roulier_picking_batch
branch
from
1c2e92d to
28dddcb
Compare
sebastienbeau
force-pushed
the
14.0-add-delivery_roulier_picking_batch
branch
from
0240730 to
f9118c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows to generate a unique delivery label/tracking for a whole batch of
pickings.
The batch pickings operations will be grouped in a single delivery package if they are
not already in a delivery package. In case of a batch with multiple packages, a label
per package will be created.
This module is only compatible with
delivery_rouliercarriers.