Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] [MIG] delivery_carrier_partner #893

Open
wants to merge 13 commits into
base: 18.0
Choose a base branch
from

Conversation

Borruso
Copy link

@Borruso Borruso commented Oct 18, 2024

migration from 17.0 to 18.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso force-pushed the 18.0-mig-delivery_carrier_partner branch from a152877 to cb51630 Compare October 18, 2024 08:07
@salvorapi
Copy link

Hi @Borruso ,

good work! I think that you just need to add a simple test case and it's done. 👍 💯

@Borruso Borruso force-pushed the 18.0-mig-delivery_carrier_partner branch 2 times, most recently from 1fc287b to 145140f Compare November 22, 2024 09:10
Copy link

@salvorapi salvorapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Christian-RB
Copy link

Thanks for your contribution! Can you squash the test commit into the Migration one?

@Borruso Borruso force-pushed the 18.0-mig-delivery_carrier_partner branch from 145140f to d02894f Compare November 22, 2024 10:55
@Borruso
Copy link
Author

Borruso commented Nov 22, 2024

Thanks for your contribution! Can you squash the test commit into the Migration one?

Can you check?

Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot migration delivery_carrier_partner

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 22, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 22, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.