-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][10.0] base_delivery_carrier_files[_document], delivery_carrier_file_tnt #206
[MIG][10.0] base_delivery_carrier_files[_document], delivery_carrier_file_tnt #206
Conversation
Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests |
9d1be31
to
947cf64
Compare
@pedrobaeza both this PR and this one remain red, even though I have the feeling I fixed all things. Could you advise me on what I still can do to make this green? |
There are warnings on runbot:
|
@thomaspaulb Do you plan to finish this ? |
4e42c31
to
42d3d74
Compare
@rousseldenis I think it's now finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the code and tested this module. Everything is ok.
@gjotten How about a functional review here? We've been using this one a long time and its 12.0 port is about to get merged also. |
@rousseldenis Could you be the merging angel here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 225bcdb. Thanks a lot for contributing to OCA. ❤️ |
Replaces #184