Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][10.0] base_delivery_carrier_files[_document], delivery_carrier_file_tnt #206

Merged
merged 9 commits into from
Sep 28, 2021

Conversation

thomaspaulb
Copy link

Replaces #184

@pedrobaeza
Copy link
Member

Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@pedrobaeza pedrobaeza mentioned this pull request Jul 17, 2019
13 tasks
@thomaspaulb thomaspaulb force-pushed the 10.0-mig-base_delivery_files2 branch 2 times, most recently from 9d1be31 to 947cf64 Compare July 17, 2019 12:36
@thomaspaulb
Copy link
Author

@pedrobaeza both this PR and this one remain red, even though I have the feeling I fixed all things. Could you advise me on what I still can do to make this green?

@pedrobaeza
Copy link
Member

There are warnings on runbot:

2019-07-17 12:43:10,507 6729 WARNING openerp_test odoo.addons.base_delivery_carrier_label.models.stock_pack_operation: Type conversion not implemented for product 43
2019-07-17 12:43:10,507 6729 WARNING openerp_test odoo.addons.base_delivery_carrier_label.models.stock_pack_operation: Type conversion not implemented for product 45
2019-07-17 12:43:42,286 6729 WARNING openerp_test odoo.modules.loading: module delivery_carrier_file_tnt: key 'update_xml' is deprecated in favor of 'data' for file 'carrier_file_view.xml'.

@rousseldenis
Copy link
Contributor

@thomaspaulb Do you plan to finish this ?

@thomaspaulb thomaspaulb force-pushed the 10.0-mig-base_delivery_files2 branch from 4e42c31 to 42d3d74 Compare November 12, 2019 12:42
@thomaspaulb
Copy link
Author

@rousseldenis I think it's now finished.

@rousseldenis rousseldenis added this to the 10.0 milestone Nov 12, 2019
Copy link
Member

@MPoch-PlanetaTIC MPoch-PlanetaTIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code and tested this module. Everything is ok.

@thomaspaulb
Copy link
Author

@gjotten How about a functional review here? We've been using this one a long time and its 12.0 port is about to get merged also.

@thomaspaulb
Copy link
Author

@rousseldenis Could you be the merging angel here

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-206-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 584b582 into OCA:10.0 Sep 28, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 225bcdb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants