Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] Backport from 14.0 to 12.0 crm_security_group #597

Open
wants to merge 18 commits into
base: 12.0
Choose a base branch
from

Conversation

quentinDupont
Copy link

@quentinDupont quentinDupont commented Sep 25, 2024

Changes from 14.0 in this commit :

  • with_context → sudo for test python
  • remove right access of some fields
  • adjust permissions rights for other module (crm_phonecall) (the right changes was made in migration 14.0 here)

Thanks for @victoralmau for all the work, very useful for us !

@quentinDupont quentinDupont force-pushed the 12.0-mig-crm_security_group branch from 94e9bd5 to 95a2474 Compare September 25, 2024 09:49
Copy link

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi ! thanks for porting this module ! a blocking remark inline.

crm_security_group/security/ir.model.access.csv Outdated Show resolved Hide resolved
Comment on lines 6 to 9
access_crm_tag_own_leads,sale_team.crm.tag.own.leads,sales_team.model_crm_tag,crm_security_group.group_crm_own_leads,1,1,1,0
access_crm_tag_manager,sale_team.crm.tag.manager,sales_team.model_crm_tag,crm_security_group.group_crm_manager,1,1,1,1
access_crm_lead_scoring_frequency_user,crm.lead.scoring.frequency.user,crm.model_crm_lead_scoring_frequency,crm_security_group.group_crm_own_leads,1,0,0,0
access_crm_lead_scoring_frequency_field_user,crm.lead.scoring.frequency.field.user,crm.model_crm_lead_scoring_frequency_field,crm_security_group.group_crm_own_leads,1,0,0,0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a reason to remove that lines ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep ! Theses fields were created post version 12 :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thansk !

@quentinDupont quentinDupont force-pushed the 12.0-mig-crm_security_group branch from 95a2474 to 0e5b6db Compare September 26, 2024 07:59
@quentinDupont
Copy link
Author

CI is red in this repo at the moment 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants