Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] crm_salesperson_planner: Migration to 17.0 #585

Merged
merged 15 commits into from
Sep 26, 2024

Conversation

BernatObrador
Copy link

@BernatObrador BernatObrador commented Jul 22, 2024

Module migrated to version 17.0

cc https://github.com/APSL 158506

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

Issue #525

@BernatObrador BernatObrador mentioned this pull request Jul 22, 2024
20 tasks
@BernatObrador BernatObrador force-pushed the 17.0-mig-crm_salesperson_planner branch from 61ce6e8 to 815e231 Compare July 22, 2024 12:37
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The Salesperson Visits view don't see good.

@BernatObrador BernatObrador force-pushed the 17.0-mig-crm_salesperson_planner branch 2 times, most recently from 0bcfd6c to 42daedb Compare July 22, 2024 14:03
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gerardoOperu and others added 9 commits July 22, 2024 16:34
Currently translated at 100.0% (196 of 196 strings)

Translation: crm-16.0/crm-16.0-crm_salesperson_planner
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_salesperson_planner/es/
Changes done:

- Removed the (unnecessary) recurrence field from templates.
- Recurrence fields (from calendar.event) are set as store=True.
- Create an onchange to avoid inconsistent values by UX.
- Modified the form view to make it more functional (similar to calendar.event).
- Consider in _get_max_date() if a deadline (until) has been set.

TT48238
Currently translated at 100.0% (186 of 186 strings)

Translation: crm-16.0/crm-16.0-crm_salesperson_planner
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_salesperson_planner/es/
Currently translated at 100.0% (186 of 186 strings)

Translation: crm-16.0/crm-16.0-crm_salesperson_planner
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_salesperson_planner/it/
@BernatObrador BernatObrador force-pushed the 17.0-mig-crm_salesperson_planner branch from 42daedb to ccf6f8f Compare July 22, 2024 14:34
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and works as intended

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@BernatObrador BernatObrador force-pushed the 17.0-mig-crm_salesperson_planner branch from ccf6f8f to 0e43619 Compare August 21, 2024 06:21
@gurneyalex
Copy link
Member

/ocabot migration crm_salesperson_planner

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 29, 2024
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-585-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b73fbb7 into OCA:17.0 Sep 26, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a48db4d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.