-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] crm_stage_probability: Migration to 16.0 #531
[16.0][MIG] crm_stage_probability: Migration to 16.0 #531
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-15.0/crm-15.0-crm_stage_probability Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_stage_probability/
795a117
to
77d7868
Compare
/ocabot migration crm_stage_probability |
Sorry @remi-filament you are not allowed to mark the addon tobe migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
/ocabot migration crm_stage_probability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review.
LGTM, thank you @remi-filament
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split the last commit into two according to migration guide?
[IMP] crm_stage_probability: black, isort, prettier
[MIG] crm_stage_probability: Migration to 16.0
you can have a look here, which file should be in which commit:
https://github.com/c4a8-odoo/module-oca-crm/commits/16.0-mig-crm_stage_probability/
The rest looks very good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM 👍🏻
77d7868
to
5835b4a
Compare
5835b4a
to
d9475bc
Compare
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 2f22747. Thanks a lot for contributing to OCA. ❤️ |
No description provided.