Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] crm_stage_probability: Migration to 16.0 #531

Merged
merged 14 commits into from
Dec 21, 2023

Conversation

remi-filament
Copy link

No description provided.

@remi-filament remi-filament force-pushed the 16.0-mig-crm_stage_probability branch from 795a117 to 77d7868 Compare November 20, 2023 10:57
@remi-filament
Copy link
Author

/ocabot migration crm_stage_probability

@OCA-git-bot
Copy link
Contributor

Sorry @remi-filament you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@pedrobaeza
Copy link
Member

/ocabot migration crm_stage_probability

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 20, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 20, 2023
22 tasks
@rafaelbn rafaelbn requested a review from fcvalgar November 20, 2023 20:48
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

LGTM, thank you @remi-filament

Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split the last commit into two according to migration guide?

[IMP] crm_stage_probability: black, isort, prettier
[MIG] crm_stage_probability: Migration to 16.0

you can have a look here, which file should be in which commit:
https://github.com/c4a8-odoo/module-oca-crm/commits/16.0-mig-crm_stage_probability/

The rest looks very good.

crm_stage_probability/views/crm_lead.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍🏻

@remi-filament remi-filament force-pushed the 16.0-mig-crm_stage_probability branch from 77d7868 to 5835b4a Compare December 20, 2023 13:20
@remi-filament remi-filament force-pushed the 16.0-mig-crm_stage_probability branch from 5835b4a to d9475bc Compare December 20, 2023 13:28
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-531-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c214472 into OCA:16.0 Dec 21, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2f22747. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.