Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] crm_lead_vat: Migration to 17.0 #530

Merged
merged 27 commits into from
Nov 24, 2023

Conversation

peluko00
Copy link

No description provided.

Ivorra78 and others added 26 commits November 16, 2023 11:12
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/es/
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-12.0/crm-12.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_vat/pt_BR/
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-12.0/crm-12.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_vat/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-12.0/crm-12.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_vat/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-14.0/crm-14.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_vat/fr/
- Add behavior to sync vat between partner and lead.

@moduon MT-3130 @rafaelbn

Co-authored-by: Rafael Blasco <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-15.0/crm-15.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_vat/
Currently translated at 100.0% (5 of 5 strings)

Translation: crm-16.0/crm-16.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_vat/it/
Currently translated at 100.0% (5 of 5 strings)

Translation: crm-16.0/crm-16.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_vat/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-16.0/crm-16.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_vat/
@peluko00
Copy link
Author

peluko00 commented Nov 16, 2023

Module migrated to version 17.0

cc https://github.com/APSL 148474

@miquelalzanillas @lbarry-apsl @javierobcn @samoros1 please review

@miquelalzanillas
Copy link

Working!

@peluko00 peluko00 mentioned this pull request Nov 16, 2023
20 tasks
@samoros1
Copy link

Functionally reviewed working as expected!

@@ -6,7 +6,7 @@

class LeadCase(TransactionCase):
def setUp(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use setUpClass

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it!

Copy link

@samoros1 samoros1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Functionally working as expected.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@peluko00 peluko00 force-pushed the 17.0-mig-crm_lead_vat branch from b361b28 to 3d05084 Compare November 23, 2023 07:14
Copy link

@javierobcn javierobcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-530-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza
Copy link
Member

/ocabot migration crm_lead_vat

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 24, 2023
@OCA-git-bot OCA-git-bot merged commit 4b2c916 into OCA:17.0 Nov 24, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e9c6594. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.