[MIG] crm_phonecall: Migration to 17.0

crm_phonecall/README.rst

@@ -17,13 +17,13 @@ CRM Phone Calls
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github
-    :target: https://github.com/OCA/crm/tree/16.0/crm_phonecall
+    :target: https://github.com/OCA/crm/tree/17.0/crm_phonecall
     :alt: OCA/crm
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall
+    :target: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_phonecall
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=17.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -40,64 +40,66 @@ Usage
 
 To use this module, you need to:
 
-#. Go to *CRM > Phone Calls > Logged Calls > New*.
-#. If your user has *Show Scheduled Calls Menu* permission, you will see
+1. Go to *CRM > Phone Calls > Logged Calls > New*.
+2. If your user has *Show Scheduled Calls Menu* permission, you will see
    scheduled calls menu too.
-#. In any moment you can schedule another call, schedule a meeting or convert
-   call contact to opportunity.
-#. Calls can be categorized and you can manage categories in *CRM >
+3. In any moment you can schedule another call, schedule a meeting or
+   convert call contact to opportunity.
+4. Calls can be categorized and you can manage categories in *CRM >
    Configuration > Phone Calls > Categories*.
-#. Calls can be analyzed in *CRM > Reporting > Phone Calls Analysis*.
+5. Calls can be analyzed in *CRM > Reporting > Phone Calls Analysis*.
 
 Known issues / Roadmap
 ======================
 
-* Simplify the function schedule_another_phonecall returning always a recordset
+-  Simplify the function schedule_another_phonecall returning always a
+   recordset
 
 Bug Tracker
 ===========
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/crm/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_phonecall%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_phonecall%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
 Credits
 =======
 
 Authors
-~~~~~~~
+-------
 
 * Odoo S.A.
 * Tecnativa
 
 Contributors
-~~~~~~~~~~~~
+------------
 
-* Odoo S.A.
-* `Tecnativa <https://www.tecnativa.com>`_
-
-  * Vicent Cubells
-  * Jairo Llopis
-  * David Vidal
-  * Alexandre Díaz
-  * Stefan Ungureanu
+-  Odoo S.A.
+-  `Tecnativa <https://www.tecnativa.com>`__
 
-* RIDA YAHLA <[email protected]>
+   -  Vicent Cubells
+   -  Jairo Llopis
+   -  David Vidal
+   -  Alexandre Díaz
+   -  Stefan Ungureanu
 
-* Anand Kansagra <[email protected]>
+-  RIDA YAHLA <[email protected]>
+-  Anand Kansagra <[email protected]>
+-  `Druidoo <https://www.druidoo.io>`__
 
-* `Druidoo <https://www.druidoo.io>`_
+   -  Iván Todorovich <[email protected]>
+   -  Manuel Marquez <[email protected]>
 
-  * Iván Todorovich <[email protected]>
-  * Manuel Marquez <[email protected]>
+-  Ruchir Shukla <[email protected]>
+-  `APSL <https://apsl.tech>`__:
 
-* Ruchir Shukla <ruchir@bizzappdev.com>
+   -  Antoni Marroig <toni.marroig1@gmail.com>
 
 Maintainers
-~~~~~~~~~~~
+-----------
 
 This module is maintained by the OCA.
 
@@ -109,6 +111,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/16.0/crm_phonecall>`_ project on GitHub.
+This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/17.0/crm_phonecall>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

crm_phonecall/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "CRM Phone Calls",
-    "version": "16.0.1.1.0",
+    "version": "17.0.1.0.0",
     "category": "Customer Relationship Management",
     "author": "Odoo S.A., Tecnativa, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/crm",

crm_phonecall/pyproject.toml

@@ -0,0 +1,3 @@
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"

crm_phonecall/readme/CONTRIBUTORS.md

@@ -0,0 +1,15 @@
+- Odoo S.A.
+- [Tecnativa](https://www.tecnativa.com)
+  - Vicent Cubells
+  - Jairo Llopis
+  - David Vidal
+  - Alexandre Díaz
+  - Stefan Ungureanu
+- RIDA YAHLA \<<[email protected]>\>
+- Anand Kansagra \<<[email protected]>\>
+- [Druidoo](https://www.druidoo.io)
+  - Iván Todorovich \<<[email protected]>\>
+  - Manuel Marquez \<<[email protected]>\>
+- Ruchir Shukla \<<[email protected]>\>
+- [APSL](https://apsl.tech):
+  - Antoni Marroig  \<<[email protected]>\>

crm_phonecall/readme/ROADMAP.md

@@ -0,0 +1,2 @@
+- Simplify the function schedule_another_phonecall returning always a
+  recordset

crm_phonecall/readme/USAGE.md

@@ -0,0 +1,10 @@
+To use this module, you need to:
+
+1.  Go to *CRM \> Phone Calls \> Logged Calls \> New*.
+2.  If your user has *Show Scheduled Calls Menu* permission, you will
+    see scheduled calls menu too.
+3.  In any moment you can schedule another call, schedule a meeting or
+    convert call contact to opportunity.
+4.  Calls can be categorized and you can manage categories in *CRM \>
+    Configuration \> Phone Calls \> Categories*.
+5.  Calls can be analyzed in *CRM \> Reporting \> Phone Calls Analysis*.

crm_phonecall/static/description/index.html

@@ -369,7 +369,7 @@ <h1 class="title">CRM Phone Calls</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:cf4a0d7435295b9514f8e21035ca71ca4f9253e50121b723f9c293cec34b3509
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/crm/tree/16.0/crm_phonecall"><img alt="OCA/crm" src="https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/crm&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/crm/tree/17.0/crm_phonecall"><img alt="OCA/crm" src="https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_phonecall"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/crm&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module allows to manage phone calls in order to analyze them.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
@@ -392,8 +392,8 @@ <h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
 <li>Go to <em>CRM &gt; Phone Calls &gt; Logged Calls &gt; New</em>.</li>
 <li>If your user has <em>Show Scheduled Calls Menu</em> permission, you will see
 scheduled calls menu too.</li>
-<li>In any moment you can schedule another call, schedule a meeting or convert
-call contact to opportunity.</li>
+<li>In any moment you can schedule another call, schedule a meeting or
+convert call contact to opportunity.</li>
 <li>Calls can be categorized and you can manage categories in <em>CRM &gt;
 Configuration &gt; Phone Calls &gt; Categories</em>.</li>
 <li>Calls can be analyzed in <em>CRM &gt; Reporting &gt; Phone Calls Analysis</em>.</li>
@@ -402,15 +402,16 @@ <h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
 <div class="section" id="known-issues-roadmap">
 <h1><a class="toc-backref" href="#toc-entry-2">Known issues / Roadmap</a></h1>
 <ul class="simple">
-<li>Simplify the function schedule_another_phonecall returning always a recordset</li>
+<li>Simplify the function schedule_another_phonecall returning always a
+recordset</li>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
 <h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/crm/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/crm/issues/new?body=module:%20crm_phonecall%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/crm/issues/new?body=module:%20crm_phonecall%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -442,6 +443,10 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 </ul>
 </li>
 <li>Ruchir Shukla &lt;<a class="reference external" href="mailto:ruchir&#64;bizzappdev.com">ruchir&#64;bizzappdev.com</a>&gt;</li>
+<li><a class="reference external" href="https://apsl.tech">APSL</a>:<ul>
+<li>Antoni Marroig &lt;<a class="reference external" href="mailto:toni.marroig1&#64;gmail.com">toni.marroig1&#64;gmail.com</a>&gt;</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -451,7 +456,7 @@ <h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/crm/tree/16.0/crm_phonecall">OCA/crm</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/crm/tree/17.0/crm_phonecall">OCA/crm</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

crm_phonecall/views/crm_phonecall_view.xml

@@ -41,15 +41,14 @@
                 <button
                     icon="fa-calendar"
                     name="action_make_meeting"
-                    states="open,pending"
+                    invisible="state not in ['open', 'pending']"
                     string="Meeting"
                     type="object"
                 />
                 <button
-                    attrs="{'invisible':[('opportunity_id','!=',False)]}"
+                    invisible="opportunity_id or state not in ['open', 'pending']"
                     icon="fa-hand-pointer-o"
                     name="action_button_convert2opportunity"
-                    states="open,pending"
                     string="Convert to Opportunity"
                     type="object"
                 />
@@ -78,7 +77,7 @@
                 <sheet string="Phone Call">
                     <div class="oe_button_box" name="button_box">
                         <button
-                            attrs="{'invisible':[ '|', ('opportunity_id','!=',False), ('state', 'not in', ('open', 'done'))]}"
+                            invisible="opportunity_id or state not in ['open', 'done']"
                             class="oe_stat_button"
                             help="Convert To Opportunity"
                             icon="fa-star"
@@ -221,10 +220,9 @@
                     type="object"
                 />
                 <button
-                    attrs="{'invisible':[('opportunity_id','!=',False)]}"
+                    invisible="opportunity_id or state != 'open' or state != 'pending'"
                     icon="fa-hand-pointer-o"
                     name="action_button_convert2opportunity"
-                    states="open,pending"
                     string="Convert to Opportunity"
                     type="object"
                 />

crm_phonecall/views/res_config_settings_views.xml

@@ -5,29 +5,15 @@
         <field name="model">res.config.settings</field>
         <field name="inherit_id" ref="crm.res_config_settings_view_form" />
         <field name="arch" type="xml">
-            <div data-string="CRM" position="inside">
-                <h2>Phonecalls</h2>
-                <div class="row mt16 o_settings_container">
-                    <div class="col-lg-6 o_setting_box">
-                        <div class="o_setting_left_pane">
-                            <field name="group_show_form_view" />
-                        </div>
-                        <div
-                            class="o_setting_right_pane"
-                            id="crm_phonecall_show_form_settings"
-                        >
-                            <label
-                                for="group_show_form_view"
-                                string="Enable form view for phone calls"
-                            />
-                            <div class="text-muted">
-                                By default form view is disabled for calls, with this
-                                setting it is enabled for all users.
-                            </div>
-                        </div>
-                    </div>
-                </div>
-            </div>
+            <xpath expr="//app[@name='crm']" position="inside">
+                <block title="Phonecalls" name="o_settings_container">
+                    <setting
+                        help="By default form view is disabled for calls, with this setting it is enabled for all users."
+                    >
+                        <field name="group_show_form_view" />
+                    </setting>
+                </block>
+            </xpath>
         </field>
     </record>
 </odoo>

crm_phonecall/wizard/crm_phonecall_to_phonecall_view.xml

@@ -8,13 +8,13 @@
                 <group>
                     <group>
                         <field name="action" />
-                        <field attrs="{'readonly': [(1,'=',1)]}" name="partner_id" />
+                        <field readonly="1" name="partner_id" />
                         <field groups="sales_team.group_sale_salesman" name="team_id" />
                     </group>
                     <group>
                         <field name="name" />
                         <field
-                            attrs="{'invisible': [('action','=','log')]}"
+                            invisible="action == 'log'"
                             name="date"
                             string="Planned Date"
                         />
@@ -27,14 +27,14 @@
                 </group>
                 <footer>
                     <button
-                        attrs="{'invisible' : [('action', '!=', 'log')]}"
+                        invisible="action != 'log'"
                         class="oe_highlight"
                         name="action_schedule"
                         string="Log Call"
                         type="object"
                     />
                     <button
-                        attrs="{'invisible' : [('action', '!=', 'schedule')]}"
+                        invisible="action != 'schedule'"
                         class="oe_highlight"
                         name="action_schedule"
                         string="Schedule Call"