[MIG][crm_won_reason] Migration to 18.0

OCA · Nov 15, 2024 · 3dfb08c · 3dfb08c
1 parent e9b655c
commit 3dfb08c
Show file tree

Hide file tree

Showing 11 changed files with 36 additions and 29 deletions.
diff --git a/crm_won_reason/README.rst b/crm_won_reason/README.rst
@@ -17,18 +17,19 @@ CRM won reason
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github
-    :target: https://github.com/OCA/crm/tree/15.0/crm_won_reason
+    :target: https://github.com/OCA/crm/tree/18.0/crm_won_reason
     :alt: OCA/crm
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_won_reason
+    :target: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_won_reason
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=15.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
-This module adds possibility to define lost & won reasons to be applied on leads.
+This module adds possibility to define lost & won reasons to be applied
+on leads.
 
 **Table of contents**
 
@@ -41,25 +42,25 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/crm/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_won_reason%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_won_reason%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
 Credits
 =======
 
 Authors
-~~~~~~~
+-------
 
 * Camptocamp
 
 Contributors
-~~~~~~~~~~~~
+------------
 
-* Anna Janiszewska <[email protected]>
+- Anna Janiszewska <[email protected]>
 
 Maintainers
-~~~~~~~~~~~
+-----------
 
 This module is maintained by the OCA.
 
@@ -79,6 +80,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-ajaniszewska-dev| 
 
-This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/15.0/crm_won_reason>`_ project on GitHub.
+This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/18.0/crm_won_reason>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/crm_won_reason/__manifest__.py b/crm_won_reason/__manifest__.py
@@ -3,7 +3,7 @@
 
 {
     "name": "CRM won reason",
-    "version": "15.0.1.0.0",
+    "version": "18.0.1.0.0",
     "category": "Customer Relationship Management",
     "author": "Camptocamp, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/crm",

diff --git a/crm_won_reason/pyproject.toml b/crm_won_reason/pyproject.toml
@@ -0,0 +1,3 @@
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"
diff --git a/crm_won_reason/readme/CONTRIBUTORS.md b/crm_won_reason/readme/CONTRIBUTORS.md
@@ -0,0 +1 @@
+- Anna Janiszewska \<<[email protected]>\>
diff --git a/crm_won_reason/readme/CONTRIBUTORS.rst b/crm_won_reason/readme/CONTRIBUTORS.rst
diff --git a/crm_won_reason/readme/DESCRIPTION.rst → crm_won_reason/readme/DESCRIPTION.md b/crm_won_reason/readme/DESCRIPTION.rst → crm_won_reason/readme/DESCRIPTION.md
@@ -1 +1,2 @@
-This module adds possibility to define lost & won reasons to be applied on leads.
+This module adds possibility to define lost & won reasons to be applied
+on leads.
diff --git a/crm_won_reason/security/ir.model.access.csv b/crm_won_reason/security/ir.model.access.csv
@@ -1,2 +1,2 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
-access_crm_lead_won,crm.lead.won,model_crm_lead_won,,1,1,1,1
+access_crm_lead_won,crm.lead.won,model_crm_lead_won,base.group_user,1,1,1,1
diff --git a/crm_won_reason/static/description/index.html b/crm_won_reason/static/description/index.html
@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="utf-8"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
@@ -9,10 +8,11 @@
 
 /*
 :Author: David Goodger ([email protected])
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -369,8 +369,9 @@ <h1 class="title">CRM won reason</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:dee9800d76ab558e0940d25d9a45a47a4dc933e68c11aa4e8d60d4c8379691ed
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/crm/tree/15.0/crm_won_reason"><img alt="OCA/crm" src="https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_won_reason"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/crm&amp;target_branch=15.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
-<p>This module adds possibility to define lost &amp; won reasons to be applied on leads.</p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/crm/tree/18.0/crm_won_reason"><img alt="OCA/crm" src="https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_won_reason"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/crm&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p>This module adds possibility to define lost &amp; won reasons to be applied
+on leads.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
 <ul class="simple">
@@ -388,7 +389,7 @@ <h1><a class="toc-backref" href="#toc-entry-1">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/crm/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/crm/issues/new?body=module:%20crm_won_reason%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/crm/issues/new?body=module:%20crm_won_reason%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -408,13 +409,15 @@ <h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-5">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/ajaniszewska-dev"><img alt="ajaniszewska-dev" src="https://github.com/ajaniszewska-dev.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/crm/tree/15.0/crm_won_reason">OCA/crm</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/crm/tree/18.0/crm_won_reason">OCA/crm</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

diff --git a/crm_won_reason/tests/test_crm_lead_reason.py b/crm_won_reason/tests/test_crm_lead_reason.py
@@ -36,14 +36,14 @@ def test_won_reason(self):
 
     def test_lost_reason(self):
         crm_lead = self.crm_lead_model.create({"name": "Testing lead lost reason"})
-        crm_lead.action_set_lost(lost_reason=self.lost_reason)
+        crm_lead.action_set_lost(lost_reason_id=self.lost_reason)
         self.assertFalse(crm_lead.stage_id.is_won)
-        self.assertEqual(crm_lead.lost_reason.name, self.lost_reason.name)
+        self.assertEqual(crm_lead.lost_reason_id.name, self.lost_reason.name)
 
     def test_unspecified_reason(self):
         crm_lead = self.crm_lead_model.create(
             {"name": "Testing lead unspecified reason"}
         )
-        crm_lead.action_set_lost(lost_reason=self.unspecified_reason)
+        crm_lead.action_set_lost(lost_reason_id=self.unspecified_reason)
         self.assertFalse(crm_lead.stage_id.is_won)
-        self.assertEqual(crm_lead.lost_reason.name, self.unspecified_reason.name)
+        self.assertEqual(crm_lead.lost_reason_id.name, self.unspecified_reason.name)
diff --git a/crm_won_reason/views/crm_views.xml b/crm_won_reason/views/crm_views.xml
@@ -40,7 +40,7 @@
                     class="oe_highlight"
                     data-hotkey="w"
                     title="Mark as won"
-                    attrs="{'invisible': ['|','|', ('active','=',False), ('probability', '=', 100), ('type', '=', 'lead')]}"
+                    invisible="active == False or probability == 100 or type == 'lead'"
                 />
             </xpath>
         </field>

diff --git a/crm_won_reason/wizard/crm_lead_won.xml b/crm_won_reason/wizard/crm_lead_won.xml
@@ -35,5 +35,4 @@
         <field name="view_id" ref="crm_lead_win_view_form" />
         <field name="target">new</field>
     </record>
-
 </odoo>