Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] connector_base_product: Migration to 16.0 #444

Merged
merged 26 commits into from
Mar 6, 2023
Merged

[16.0][MIG] connector_base_product: Migration to 16.0 #444

merged 26 commits into from
Mar 6, 2023

Conversation

asierneiradev
Copy link
Contributor

@asierneiradev asierneiradev commented Oct 4, 2022 •
edited

@asierneiradev asierneiradev changed the title 16.0 mig connector base product [16.0][MIG] connector_base_product: Migration to 16.0 Oct 4, 2022
@asierneiradev asierneiradev mentioned this pull request Oct 10, 2022
Closed
6 tasks
@wpichler wpichler mentioned this pull request Oct 25, 2022
Open
@asierneiradev asierneiradev force-pushed the 16.0-mig-connector_base_product branch 2 times, most recently from 8713ffa to 9fc9b33 Compare November 24, 2022 14:41
@asierneiradev asierneiradev force-pushed the 16.0-mig-connector_base_product branch 5 times, most recently from 6f57c59 to 6229e93 Compare January 31, 2023 06:00
@asierneiradev asierneiradev mentioned this pull request Feb 1, 2023
Merged
@simahawk
Copy link
Contributor

/ocabot migration connector_base_product

@asierneiradev
Copy link
Contributor Author

Wouldn't it be necessary to first have merge connector in order to remove the dependency in test-requirements.txt?

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 23, 2023
bealdav and others added 14 commits February 23, 2023 10:26
@bealdav @asierneiradev
[ADD] connector_base_product module to avoid ecommerce addons depende…
db56764 
…ncy for product synchro
@bealdav @asierneiradev
[FIX] fix __openerp__.py
03cac8a
@guewen @asierneiradev
pep8 / flake8 fixes
c3ba3e3
@guewen @asierneiradev
Use the new links for websites (with odoo) and for the prestashop
6b6f3b6 
connector
@gurneyalex @asierneiradev
Add OCA as author of OCA addons
89c5973 
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@flotho @asierneiradev
Re add notebook page on product template
e4fdea7
@flotho @asierneiradev
Change name of the view
eb5625c
@flotho @asierneiradev
Change model of the view
0c8529f
@sbidoul @asierneiradev
[UPD] prefix versions with 8.0
2a2397d
@pedrobaeza @asierneiradev
[MIG] Make modules uninstallable
383b481
@atchuthan @asierneiradev
[PORT][9.0] connector_base_product
d535239
@sbidoul @asierneiradev
[FIX] remove en.po that was erroneously created by transbot
3edb0bc
@guewen @asierneiradev
Set addons uninstallable
0ccf76a
@lmignon @asierneiradev
[MIG] connector_base_product: Migrated to 10.0
f04c4a9
@asierneiradev
Copy link
Contributor Author

asierneiradev commented Feb 23, 2023 •
edited

Hi @simahawk @sbidoul !
Branch rebased and test-requirements.txt dependency removed.
Could it be merged ?
Thank you very much

@asierneiradev
Copy link
Contributor Author

Hi @simahawk ,

would it be possible to launch again the command to merge?

By removing the associated dependency, the entire repository would be migrated.

Thank you very much for your time, if I can help you in any way I will be glad to do it.

Regards

@simahawk
Copy link
Contributor

simahawk commented Mar 1, 2023

@asierneiradev you shouldn't touch .copier-answers manually. Please trash the last commit and rebase on 16.0

simahawk
simahawk reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG otherwise

@asierneiradev asierneiradev force-pushed the 16.0-mig-connector_base_product branch 3 times, most recently from ecc7593 to e2b2e33 Compare March 1, 2023 07:51
@asierneiradev
Copy link
Contributor Author

@asierneiradev you shouldn't touch .copier-answers manually. Please trash the last commit and rebase on 16.0

Done!
But now the tests are failing, and I can't understand why.
Could you help me?

@simahawk
Copy link
Contributor

simahawk commented Mar 1, 2023

I think there's a problem w/ a test in test_component. The class TestEventWorkContext does not inherit from Odoo base case - because there's actually NO need for it - but the odoo test suite runner expects all test class to have the meta class MetaCase which sets the test_module attribute.
I'm re-running a build on 16.0 to verify it.

@simahawk
Copy link
Contributor

simahawk commented Mar 1, 2023

Reproduced on 16.0 https://github.com/OCA/connector/actions/runs/4250721530/jobs/7501676448#step:8:103
I'll provide a fix.

@simahawk
Copy link
Contributor

simahawk commented Mar 1, 2023

FYI I'm stuck here #461

@simahawk
Copy link
Contributor

simahawk commented Mar 1, 2023

Fix here odoo/odoo#114007

@asierneiradev
Copy link
Contributor Author

Fix here odoo/odoo#114007

Great job @simahawk !
Thank you very much for the help and your time.
I will keep an eye on the evolution of the FIX.
Once it is merged, I will include it by rebasing on 16.0.

Thanks for everything, best regards!

@asierneiradev asierneiradev force-pushed the 16.0-mig-connector_base_product branch from e2b2e33 to b1ebd73 Compare March 6, 2023 06:00
@asierneiradev asierneiradev force-pushed the 16.0-mig-connector_base_product branch from b1ebd73 to 773946b Compare March 6, 2023 06:00
@asierneiradev
Copy link
Contributor Author

asierneiradev commented Mar 6, 2023 •
edited

Hi @simahawk !

Thanks to your FIX, I have relaunched the tests and it seems ready to be merged and ultimately leave the connector module completely migrated.

Thank you very much for your help

@simahawk
Copy link
Contributor

simahawk commented Mar 6, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-444-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b543d01 into OCA:16.0 Mar 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dfc0655. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet