[16.0][MIG] component + test_component: Migration to 16.0 #441
Conversation
|
Hey @asierneiradev, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
/ocabot migration component |
|
Sorry @hugosantosred you are not allowed to mark the addon tobe migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
Hey @asierneiradev, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
asierneiradev
force-pushed
the
16.0-mig-component
branch
2 times, most recently
from
f7aac6a
to
a350b85
Compare
|
Hi @flachica ! |
|
/ocabot migration component |
|
Sorry @asierneiradev you are not allowed to mark the addon tobe migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
/ocabot migration component |
|
Can you rebase pls? I'd like to see runboat build running and likely we'll have a problem w/ pre-commit as we have to sync from the template. |
asierneiradev
force-pushed
the
16.0-mig-component
branch
from
a350b85
to
5805168
Compare
The favorite lookup should be by 'usage' (kinda interface) and by model
name ('components()' method). The lookup by component name should
normally not be used as it reduces the flexibility. Using a different
method for this lookup discourage its usage. Also, the lookup by
component name completely ignores the current collection, which is bad
or not bad depending of what you want to achieve.
when inheriting from multiple components, we might inadvertly override a value with None
Used for instance by the 'ecommerce' components
The mapping methods are now built by the component initialization when the "aggregated" class is built.
And remove automatic naming from class name, not explicit enough,
especially when we have to inherit from one.
We could take the total opposite and only use class names components:
class MyComponent(Component):
...
class MyComponentExtended(Component):
_inherit = 'MyComponent'
But it would be less close to the odoo's API.
asierneiradev
force-pushed
the
16.0-mig-component
branch
2 times, most recently
from
3bd660f
to
999080e
Compare
|
Hi @simahawk ! |
|
Please include #448, which was merged in the 15.0 branch recently. |
Add a link to the Introduction to Odoo Components article by Guewen Baconnier
asierneiradev
force-pushed
the
16.0-mig-component
branch
from
999080e
to
f4b3797
Compare
|
Is already included. Best regards !
|
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 7e70b2a. Thanks a lot for contributing to OCA. ❤️ |
#440 : component + test_component