-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] component: Migration to 15.0 #423
Conversation
d7f8b68
to
30133ca
Compare
@simahawk it used to work. Now registry isn't cleaned anymore. I got errors on tests:
Tried |
b7d75d3
to
9096fe0
Compare
@simahawk it runs without issues locally, and also |
the point is not if it works or not. The point is that the setup should happen on the class and not on each test. I'll have a look tomorrow. |
I hope it's. I watched your OCA video about testing techniques |
9096fe0
to
1f3dd06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing commit history
Please follow the migration procedure here:
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0
1f3dd06
to
b452878
Compare
@dreispt you are late 🤣 The history is there because the repo has been re-initialized w/ modules uninstallable 😉 See #420 (comment) |
pls squash the last commit once you have done |
[UPD] connector settings to include component
b452878
to
370efd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just realized you miss https://github.com/OCA/connector/blob/15.0/test_component
@simahawk definitely didn't pay attention to other modules. Will also update test_component, but to me makes sense not to open separate PR and add just new commit here. Is it ok? |
no, because the module is called |
test_component migrated on #424 |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 70f5dc1. Thanks a lot for contributing to OCA. ❤️ |
Hello @simahawk , can you give a short explanation why SavepointComponentCase was removed from the tests? Thanks |
Hello @john-herholz-dt, I just ran into the same problem, and I found that Regards. |
ref: BSRD-470