[18.0] [MIG] product_brand #211

samirGuesmi · 2024-10-10T15:57:37Z

Migarate product_brand to v18

… Thanks to NetAndCo who starts the module

* add smart button, move menu to a more visible position. * show brand in product.template kanban and tree views. * show brand in product variant kanban and tree views. * add product_brand kanban view. * update module's README and manifest file. * Search and group by brand for both product.product and product.template. * Convert model to new APIs. * Refactor products_count computation using product_ids one2many field. * Add public read access to product.brand (fixes 403 error on webshop for public user). * Make brand name required.

Migration to 10.0

Old form view was out of order: form blocks misaligned, because it was not using Odoo 10 views styling and layout.

Lookup fails when the ID is formatted. The unformatted version of the data is located under `raw_value`.

Currently translated at 100,0% (21 of 21 strings) Translation: product-attribute-11.0/product-attribute-11.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/

… with other odoo apps. (#364) * Make the logo always the same width (64px). * Remove the description (200 first caracters). Not relevant for a configuration model. * Move the brand name and product count beside the image. This is the way it is displayed in partners and products kanban views.

Currently translated at 100.0% (24 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/es/

Currently translated at 37.5% (9 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/

Currently translated at 100.0% (24 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nb_NO/

Currently translated at 100.0% (24 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nl_NL/

* Rule product.brand.public has no group, this is a deprecated feature. odoo/odoo#125216 * Every access-granting rule should specify a group. odoo/odoo@ce1a4a2

astirpe

@samirGuesmi Thank you for porting this module, please check my code review and the results from my testing.

astirpe · 2024-10-13T13:11:36Z

product_brand/__manifest__.py

@@ -9,7 +9,7 @@

 {
    "name": "Product Brand Manager",
-    "version": "17.0.1.1.1",
+    "version": "18.0.1.1.1",


Should be 18.0.1.0.0

astirpe · 2024-10-13T13:35:11Z

product_brand/views/product_brand_view.xml

@@ -147,7 +147,7 @@
        <field name="model">product.template</field>
        <field name="inherit_id" ref="product.product_template_kanban_view" />
        <field name="arch" type="xml">
-            <xpath expr="//strong[hasclass('o_kanban_record_title')]" position="after">
+            <xpath expr="//div[hasclass('d-flex')]" position="after">


Avoid to do generic search on elements with class d-flex, like you are doing here:
expr="//div[hasclass('d-flex')]"

Try to use something more direct, like for example:
expr="//field[@name='name']/.." (putting /.. after the field will have the same effect as the expression above)

Thanks, Done

astirpe · 2024-10-13T13:35:52Z

product_brand/views/product_brand_view.xml

-                expr="//div[hasclass('oe_kanban_details')]//strong[1]"
-                position="after"
-            >
+            <xpath expr="//div[hasclass('d-flex')]" position="after">


Tested in runboat: when I click on the brand in the kanban view of a variant (product.product), the link doesn't work because it opens directly the variant instead of the brand. Could you check? (but seems working fine on the product.template)

Also here, avoid to do generic search on class d-flex.

It doesn't work on v17 either. I fixed it by adding the widget widget="many2one" .

samirGuesmi · 2024-10-16T10:21:33Z

@astirpe Thank you Andrea for the review.
I just pushed the fixes.

astirpe

Thank you!

OCA-git-bot · 2024-10-16T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

CasVissers-360ERP

Functional review

luc-adhoc

func review

luc-adhoc · 2024-11-12T16:13:50Z

@pedrobaeza would you set this PR to merge ? tks!

pedrobaeza · 2024-11-12T18:06:07Z

product_brand/reports/account_invoice_report.py

@@ -11,14 +12,14 @@ class AccountInvoiceReport(models.Model):

    @api.model
    def _select(self):
-        select_str = super()._select()
+        select_str = super()._select().code


Isn't there a way of not having to unwrap/wrap this? I suppose there should be a method to add new content to the existing SQL object.

zaoral

HI @samirGuesmi !
Thank you for the PR
Only we suggest one small change related to a warning that is raise in runbot,
Please could you add it to this PR?

Best Rergards

cc @cav-adhoc @vib-adhoc

zaoral · 2024-11-15T17:45:27Z

product_brand/views/product_brand_view.xml

+                <field name="products_count" />
+                <field name="description" />
+                <templates>
+                    <t t-name="kanban-box">


To avoid warning in runbot please change to card. for more info go to
odoo/odoo@233f03d

Suggested change

<t t-name="kanban-box">

<t t-name="card">

@samirGuesmi I've pushed this change because I needed our pipelines to be green :-)

@marielejeune thanks 😃

xaviedoanhduy · 2024-12-03T03:05:27Z

product_brand/views/product_brand_view.xml

+                <field name="description" />
+                <templates>
+                    <t t-name="card">
+                        <div class="oe_kanban_global_click">


class oe_kanban_global_click is deprecated in this PR: odoo/odoo#167751

xaviedoanhduy · 2024-12-03T03:05:48Z

product_brand/views/product_brand_view.xml

+                                    alt="Logo"
+                                />
+                            </div>
+                            <div class="oe_kanban_details">


oe_kanban_details is the same above

xaviedoanhduy · 2024-12-03T04:10:45Z

product_brand/views/product_brand_view.xml

+                    <t t-name="card">
+                        <div class="oe_kanban_global_click">
+                            <div class="o_kanban_image">
+                                <img


please replace this img block to <field name="logo" widget="image" class="oe_avatar" /> to fix this error below when click link to product brand from product template:

xaviedoanhduy · 2024-12-03T04:10:57Z

product_brand/views/product_brand_view.xml

+        <field name="model">product.brand</field>
+        <field name="arch" type="xml">
+            <kanban>
+                <field name="id" />


Suggested change

<field name="id" />

xaviedoanhduy · 2024-12-03T04:15:07Z

product_brand/reports/account_invoice_report.py

+        return SQL(select_str)
+
+    @api.model
+    def _group_by(self):


Suggested change

def _group_by(self):

def _group_by(self) -> SQL::

return SQL("%s, template.product_brand_id", super()._group_by())

xaviedoanhduy · 2024-12-03T04:16:55Z

product_brand/reports/account_invoice_report.py

+    product_brand_id = fields.Many2one(comodel_name="product.brand", string="Brand")
+
+    @api.model
+    def _select(self):


Suggested change

def _select(self):

def _select(self) -> SQL:

return SQL("%s, template.product_brand_id as product_brand_id", super()._select())

xaviedoanhduy · 2024-12-03T04:24:15Z

please name the pull request following this pattern: [18.0][MIG] <module>: Migration to 18.0

luc-adhoc

functional review

xaviedoanhduy · 2024-12-09T09:41:56Z

Hi, I created #215 to follow-up on your PR with the needed changes.

bguillot and others added 30 commits October 10, 2024 17:49

[INIT] init module product_brand extract from trunk-addons-community.…

53439ba

… Thanks to NetAndCo who starts the module

migration of product_brand for version 7.0

5e19136

Launchpad automatic translations update.

6826625

Set all addons to uninstallable and move them into __unported__ folder

64cbe7b

portation of product_brand to 8.0

7b95643

[MIG] product_brand :Updated module as per v9

54ee8a7

[MIG][10.0] product_brand (OCA#191)

cc4947b

Migration to 10.0

Update product_brand.py

40d186f

[IMP] product_brand: update form view for 10.0

56dfa08

Old form view was out of order: form blocks misaligned, because it was not using Odoo 10 views styling and layout.

[MIG] : Migration to 11.0 + Test

51660cd

[FIX] product_brand: Don't format the ID (#355)

7563299

Lookup fails when the ID is formatted. The unformatted version of the data is located under `raw_value`.

remove obsolete .pot files [ci skip]

83e49ef

[IMP] product_branch: Order brands by name

23725f8

product_brand: complete fr translation

2e09df6

Translated using Weblate (German)

b46a356

Currently translated at 100,0% (21 of 21 strings) Translation: product-attribute-11.0/product-attribute-11.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/

[MIG] Merge product_brand_sale_report into product_brand

a8dbdb0

[MIG] Merge product_brand_invoice_report into product_brand

5b838ce

[MIG] product_brand to 12.0

f4a53f9

[MIG] product_pricelist_direct_print: Migration to 12.0

4ada665

Translated using Weblate (Spanish)

5cec9b7

Currently translated at 100.0% (24 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/es/

Added translation using Weblate (Norwegian Bokmål)

52adf60

[12.0] [FIX] Patch product_brand (#433)

41f42a0

Translated using Weblate (Dutch)

723d349

Currently translated at 100.0% (24 of 24 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_brand/nl_NL/

[IMP] product_brand: save logo as attachment (#493)

0af49d9

[MIG][13.0] product_brand

7a27223

Added translation using Weblate (Portuguese (Brazil))

a60c457

randall-vx and others added 5 commits October 10, 2024 17:49

[FIX] product_brand: Rule product.brand.public has no group

b2d4bc3

* Rule product.brand.public has no group, this is a deprecated feature. odoo/odoo#125216 * Every access-granting rule should specify a group. odoo/odoo@ce1a4a2

[BOT] post-merge updates

2867ae6

[IMP] Remove global ACL and specify explicit routes for each line.

28f2340

[BOT] post-merge updates

4a8f32f

[BOT] post-merge updates

9e1d208

astirpe suggested changes Oct 13, 2024

View reviewed changes

samirGuesmi force-pushed the 18.0-mig-product_brand-sgu branch from 27fc8f9 to 17d528f Compare October 16, 2024 10:15

astirpe approved these changes Oct 16, 2024

View reviewed changes

samirGuesmi changed the title ~~18.0 mig product_brand~~ [18.0] [MIG] product_brand Oct 16, 2024

marielejeune approved these changes Oct 16, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 16, 2024

CasVissers-360ERP approved these changes Oct 18, 2024

View reviewed changes

luc-adhoc approved these changes Nov 4, 2024

View reviewed changes

pedrobaeza reviewed Nov 12, 2024

View reviewed changes

zaoral suggested changes Nov 15, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Nov 15, 2024

[MIG] product_brand: Migration to 18.0

d57b8d7

marielejeune force-pushed the 18.0-mig-product_brand-sgu branch from 17d528f to d57b8d7 Compare November 25, 2024 16:21

lef-adhoc mentioned this pull request Nov 26, 2024

[MIG] product_brand_report: Migration to 18.0 ingadhoc/product#708

Closed

xaviedoanhduy suggested changes Dec 3, 2024

View reviewed changes

xaviedoanhduy mentioned this pull request Dec 5, 2024

[18.0][MIG] product_brand: Migration to 18.0 xaviedoanhduy/brand#2

Open

luc-adhoc approved these changes Dec 5, 2024

View reviewed changes

xaviedoanhduy mentioned this pull request Dec 9, 2024

[18.0][MIG] product_brand: Migration to 18.0 #215

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0] [MIG] product_brand #211

[18.0] [MIG] product_brand #211

samirGuesmi commented Oct 10, 2024

astirpe left a comment

astirpe Oct 13, 2024

samirGuesmi Oct 16, 2024

astirpe Oct 13, 2024

samirGuesmi Oct 16, 2024

astirpe Oct 13, 2024

samirGuesmi Oct 16, 2024

samirGuesmi commented Oct 16, 2024

astirpe left a comment

OCA-git-bot commented Oct 16, 2024

CasVissers-360ERP left a comment

luc-adhoc left a comment

luc-adhoc commented Nov 12, 2024

pedrobaeza Nov 12, 2024

zaoral left a comment

zaoral Nov 15, 2024

marielejeune Nov 25, 2024

samirGuesmi Nov 26, 2024

xaviedoanhduy Dec 3, 2024

xaviedoanhduy Dec 3, 2024

xaviedoanhduy Dec 3, 2024 •

edited

Loading

xaviedoanhduy Dec 3, 2024

xaviedoanhduy Dec 3, 2024

xaviedoanhduy Dec 3, 2024

xaviedoanhduy commented Dec 3, 2024

luc-adhoc left a comment

xaviedoanhduy commented Dec 9, 2024

	def _group_by(self):
	def _group_by(self) -> SQL::
	return SQL("%s, template.product_brand_id", super()._group_by())

	def _select(self):
	def _select(self) -> SQL:
	return SQL("%s, template.product_brand_id as product_brand_id", super()._select())

[18.0] [MIG] product_brand #211

Are you sure you want to change the base?

[18.0] [MIG] product_brand #211

Conversation

samirGuesmi commented Oct 10, 2024

astirpe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samirGuesmi commented Oct 16, 2024

astirpe left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Oct 16, 2024

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

luc-adhoc left a comment

Choose a reason for hiding this comment

luc-adhoc commented Nov 12, 2024

Choose a reason for hiding this comment

zaoral left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xaviedoanhduy Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xaviedoanhduy commented Dec 3, 2024

luc-adhoc left a comment

Choose a reason for hiding this comment

xaviedoanhduy commented Dec 9, 2024

xaviedoanhduy Dec 3, 2024 •

edited

Loading