Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] - migration pricelist brand to 14.0 #122

Open
wants to merge 12 commits into
base: 14.0
Choose a base branch
from
Open

[14.0][MIG] - migration pricelist brand to 14.0 #122

wants to merge 12 commits into from

Conversation

cramosh
Copy link

@cramosh cramosh commented Jun 27, 2022

No description provided.

@cramosh
Copy link
Author

cramosh commented Jun 27, 2022

Hi, I need guidance to know how to solve the test errors that are appearing in the PR

@sbejaoui sbejaoui added this to the 14.0 milestone Oct 10, 2022
@sbejaoui sbejaoui removed their assignment Oct 10, 2022
@sbejaoui sbejaoui changed the title 14.0 mig pricelist brand [14.0][MIG] - migration pricelist brand to 14.0 Oct 10, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 12, 2023
@sbejaoui sbejaoui added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Feb 16, 2023
FrancescoBallerini
FrancescoBallerini approved these changes Apr 9, 2024
View reviewed changes
Copy link

@FrancescoBallerini FrancescoBallerini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional: LGTM

If pricelist is archived the rule will still be fetched (see code review).
That doesn't really impact the workflow as you shouldn't be able to fetch archived pricelist from sale order or in website context.

PR approved :-)

pricelist_brand/models/product_pricelist.py
AND (item.product_brand_id IS NULL OR item.product_brand_id = any(%s))
AND (item.pricelist_id = %s)
AND (item.date_start IS NULL OR item.date_start<=%s)
AND (item.date_end IS NULL OR item.date_end>=%s)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think a line

AND (item.active = TRUE)

is missing if compared to the original method. Has it been removed for specific reasons?

https://github.com/odoo/odoo/blob/14.0/addons/product/models/product_pricelist.py#L111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescoBallerini FrancescoBallerini FrancescoBallerini approved these changes

Assignees

@cramosh cramosh

Labels
needs review no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cramosh @FrancescoBallerini @sbejaoui @qgroulard @oca-travis @OCA-git-bot