Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] account_statement_import_online_plaid #696

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] account_statement_import_online_plaid #696

wants to merge 1 commit into from

Conversation

adasatorres
Copy link

This addon allow get your transactions using plaid.com platform.

@adasatorres adasatorres force-pushed the 16.0-add-account_statement_import_online_plaid branch 3 times, most recently from 7976fe8 to 2391203 Compare May 23, 2024 10:39
@pedrobaeza pedrobaeza changed the title [16.0][ADD] account_statement_provider_plaid [16.0][ADD] account_statement_import_online_plaid May 23, 2024
@adasatorres adasatorres force-pushed the 16.0-add-account_statement_import_online_plaid branch from 2391203 to e0c6c67 Compare May 28, 2024 11:26
Christian-RB
Christian-RB approved these changes May 28, 2024
View reviewed changes
Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution for bank statements import in USA 👍🏻

lauradiaz22
lauradiaz22 approved these changes May 28, 2024
View reviewed changes
Copy link

@lauradiaz22 lauradiaz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test OK. LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@adasatorres adasatorres force-pushed the 16.0-add-account_statement_import_online_plaid branch from b6aee78 to 9962ba4 Compare June 5, 2024 06:36
etobella
etobella reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically seems correct, however, I would make a small change

account_statement_import_online_plaid/__manifest__.py Outdated Show resolved Hide resolved
@adasatorres adasatorres force-pushed the 16.0-add-account_statement_import_online_plaid branch 5 times, most recently from 37120c4 to 6f48d2f Compare July 5, 2024 10:51
@carolinafernandez-tecnativa
Copy link
Contributor

Hi,

1- I have created new journal with this configuration:

image

When i press Pull online i got this error message:

image

But the record exists:

image

@adasatorres
Copy link
Author

Hi,

1- I have created new journal with this configuration:

image

When i press Pull online i got this error message:

image But the record exists: image

Hello @carolinafernandez-tecnativa , sorry for the delay. I have checked the mentioned issue, and it seems to be unrelated to this addon, as the problem persists even after uninstalling this addon in the runboat.

@jelenapoblet
Copy link

@pedrobaeza @etobella anything else we need here to push this through ?

@rrebollo
Copy link

rrebollo commented Nov 21, 2024 •
edited
Loading

@adasatorres @pedrobaeza @etobella I'm starting the migration to v17 from this PR. As this is not merged yet, is there any guidelines to follow?

rrebollo
rrebollo approved these changes Nov 29, 2024
View reviewed changes
Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM

account_statement_import_online_plaid/models/plaid_interface.py Show resolved Hide resolved
@rrebollo rrebollo mentioned this pull request Nov 29, 2024
Open
1 task
rrebollo
rrebollo suggested changes Nov 29, 2024
View reviewed changes
Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the plaid-python version before. Please accept my suggestion.

account_statement_import_online_plaid/__manifest__.py Outdated Show resolved Hide resolved
@adasatorres adasatorres force-pushed the 16.0-add-account_statement_import_online_plaid branch from 72ce058 to 6d0e168 Compare December 4, 2024 11:39
@pedrobaeza
Copy link
Member

Checking these days. Please wait a bit.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrebollo rrebollo rrebollo requested changes

@lauradiaz22 lauradiaz22 lauradiaz22 approved these changes

@Christian-RB Christian-RB Christian-RB approved these changes

@etobella etobella etobella approved these changes

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@adasatorres @OCA-git-bot @carolinafernandez-tecnativa @jelenapoblet @rrebollo @pedrobaeza @etobella @Christian-RB @lauradiaz22