[18.0][MIG] : Migration partner_invoicing_mode to 18.0 #1833

chaule97 · 2024-11-06T03:29:38Z

If a field is marked as readonly=True on the model, it won't be possible to import it through the Odoo import tool, so we avoid it as possible and define the readonly attribute on the views instead.

[UPD] Update partner_invoicing_mode.pot [UPD] README.rst partner_invoicing_mode 16.0.1.0.1

Translated using Weblate (Spanish) Currently translated at 100.0% (8 of 8 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/es/ [UPD] README.rst

Translated using Weblate (Italian) Currently translated at 100.0% (8 of 8 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/it/

Allow to have a better extension mechanism when having multiple invoicing modes.

The field one_invoice_per_order wasn't used correctly. So, now, create invoices using the partner option by calling the grouping option on sale orders

To improve flexibility, the invoicing grouping option could be different on the sale order level than on the partner level.

As the read_group() can aggregate sale order ids per partner, use the ids list instead.

…al field As a company can have several different invoicing address, invoicing can occur at different dates.

…tion As validation jobs could last long time if there are plenty, ensure that the wanted date is correctly set.

In order to be able to benefits from standard grouping function, override it and add missing keys. [UPD] Update partner_invoicing_mode.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/ Translated using Weblate (Italian) Currently translated at 94.4% (17 of 18 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/it/ Translated using Weblate (Italian) Currently translated at 100.0% (18 of 18 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/it/ Translated using Weblate (Spanish) Currently translated at 100.0% (18 of 18 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-17.0/account-invoicing-17.0-partner_invoicing_mode Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-partner_invoicing_mode/

Currently translated at 100.0% (18 of 18 strings) Translation: account-invoicing-17.0/account-invoicing-17.0-partner_invoicing_mode Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-partner_invoicing_mode/it/

TDu

Actually, I think there is an issue with the sale dependency that is not installed...

So I would think the change on sale.order view is not applied ?

TDu · 2024-11-06T12:51:07Z

Actually, I think there is an issue with the sale dependency that is not installed... So I would think the change on sale.order view is not applied ?
Finally installing the sale_management app and it works, so looks good 🤔
Yeah forget about my comment 🫨 sale was installed.

mmequignon · 2024-11-07T14:48:18Z

partner_invoicing_mode/tests/test_invoice_mode.py

@@ -6,7 +6,8 @@
 from freezegun import freeze_time

 from odoo import fields
-from odoo.tests.common import Form, TransactionCase
+from odoo.tests import Form
+from odoo.tests.common import TransactionCase


Why CommonPartnerInvoicingMove isn't depending on TransactionCase?
It implements setUpClass and calls super() which no parent class implements.

I have updated CommonPartnerInvoicingMove depending on TransactionCase

I would ask first the author of this: cc @rousseldenis your opinion on this change?
This CommonPartnerInvoicingMove could be implemented this way to use it as a mixin by reverse dependencies, not as a common test class.

chaule97 · 2024-11-08T07:55:21Z

Hello everyone, I have changed a little about readonly attribute in model and field

TDu · 2024-11-22T14:30:36Z

base_partition has been mergedhttps://github.com/OCA/server-tools/pull/3077 that DON'T MERGE commit can be removed. Thanks

chaule97 · 2024-11-22T17:57:48Z

base_partition has been mergedhttps://github.com/OCA/server-tools/pull/3077 that DON'T MERGE commit can be removed. Thanks

I have removed it

ivantodorovich · 2024-12-24T15:30:37Z

partner_invoicing_mode/models/res_company.py

@@ -10,5 +10,4 @@ class ResCompany(models.Model):
    invoicing_mode_standard_last_execution = fields.Datetime(
        string="Last execution (standard)",
        help="Last execution of standard invoicing.",
-        readonly=True,


Not sure I understand this change.
I can't think of a reason why we'd want tthis field to be imported

ivantodorovich · 2024-12-24T15:32:23Z

partner_invoicing_mode/models/account_invoice.py

+    _inherit = "account.move"
+
+    def _validate_invoice(self):
+        return self.sudo().action_post()


I'm not sure I understand why this method is needed.
Can't we call/delay action_post directly ?

ivantodorovich · 2024-12-24T15:33:15Z

partner_invoicing_mode/models/res_partner.py

+
+    invoicing_mode = fields.Selection([("standard", "Standard")], default="standard")
+    one_invoice_per_order = fields.Boolean(
+        default=False,


Suggested change

default=False,

redundant

ivantodorovich · 2024-12-24T15:34:50Z

partner_invoicing_mode/models/res_partner.py

+    def _update_next_invoice_date(self):
+        """
+        This will update the next invoice date from the configuration set on
+        the partner if needed (not for standard invoicing_mode).
+        """
+        return


Maybe I'm missing something..

What's the purpose of this method?
Seems rather useless..

OCA-git-bot · 2024-12-24T15:38:40Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

TDu and others added 21 commits November 4, 2024 15:55

[MIG] rename account_invoice_base_invoicing_mode

5d05c35

[UPD] Update partner_invoicing_mode.pot

8fb161d

[MIG] partner_invoicing_mode: Migration to 16.0

e5e36c6

[UPD] Update partner_invoicing_mode.pot [UPD] README.rst partner_invoicing_mode 16.0.1.0.1

[REF] partner_invoicing_mode/monthly: Better extension mechanism

aa03e98

Allow to have a better extension mechanism when having multiple invoicing modes.

[IMP] partner_invoicing_mode: Partition invoicings

161b244

The field one_invoice_per_order wasn't used correctly. So, now, create invoices using the partner option by calling the grouping option on sale orders

[IMP] partner_invoicing_mode: Add a field for next invoice date

ad5e612

[IMP] partner_invoicing_mode: Add the invoicing grouping on sale

e831f77

To improve flexibility, the invoicing grouping option could be different on the sale order level than on the partner level.

[IMP] partner_invoicing_mode: Add some hooks

0506490

[IMP] partner_invoicing_mode: Don't loop search on sale orders

a7e97ee

As the read_group() can aggregate sale order ids per partner, use the ids list instead.

[IMP] partner_invoicing_mode: Don't set next_invoice_date as commerci…

a4d5537

…al field As a company can have several different invoicing address, invoicing can occur at different dates.

[IMP] partner_invoicing_mode: Update the invoice date just after crea…

caba280

…tion As validation jobs could last long time if there are plenty, ensure that the wanted date is correctly set.

[IMP] partner_invoicing_mode: pre-commit auto fixes

66c748a

[MIG] partner_invoicing_mode: Migration to 17.0

e2515a3

[UPD] Update partner_invoicing_mode.pot

85b0085

[BOT] post-merge updates

1509e6c

[IMP] partner_invoicing_mode: pre-commit auto fixes

9d4c8d7

TDu approved these changes Nov 6, 2024

View reviewed changes

TDu reviewed Nov 6, 2024

View reviewed changes

mmequignon reviewed Nov 7, 2024

View reviewed changes

chaule97 force-pushed the 18.0-mig-partner_invoicing_mode branch from 2f73859 to 03a1367 Compare November 8, 2024 02:50

chaule97 mentioned this pull request Nov 8, 2024

[18.0][MIG]: Migration partner_invoicing_mode_monthly to 18.0 #1834

Open

chaule97 added 2 commits November 8, 2024 14:49

[MIG] partner_invoicing_mode: Migration to 18.0

8684f46

[UPD] Update testcase

a108a3f

chaule97 force-pushed the 18.0-mig-partner_invoicing_mode branch from 03a1367 to 2a89ba9 Compare November 8, 2024 07:50

chaule97 mentioned this pull request Nov 8, 2024

[18.0][MIG]: Migration partner_invoicing_mode_at_shipping to 18.0 #1835

Open

chaule97 requested a review from mmequignon November 20, 2024 10:33

chaule97 force-pushed the 18.0-mig-partner_invoicing_mode branch from 2a89ba9 to a108a3f Compare November 22, 2024 17:53

ivantodorovich approved these changes Dec 24, 2024

View reviewed changes

OCA-git-bot added the approved label Dec 24, 2024

ivantodorovich approved these changes Dec 24, 2024

View reviewed changes

OCA-git-bot added the ready to merge label Dec 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] : Migration partner_invoicing_mode to 18.0 #1833

[18.0][MIG] : Migration partner_invoicing_mode to 18.0 #1833

chaule97 commented Nov 6, 2024 •

edited

Loading

TDu left a comment

TDu commented Nov 6, 2024 •

edited

Loading

mmequignon Nov 7, 2024

chaule97 Nov 8, 2024

sebalix Dec 24, 2024

chaule97 commented Nov 8, 2024

TDu commented Nov 22, 2024

chaule97 commented Nov 22, 2024

ivantodorovich Dec 24, 2024

ivantodorovich Dec 24, 2024

ivantodorovich Dec 24, 2024

ivantodorovich Dec 24, 2024

OCA-git-bot commented Dec 24, 2024

[18.0][MIG] : Migration partner_invoicing_mode to 18.0 #1833

Are you sure you want to change the base?

[18.0][MIG] : Migration partner_invoicing_mode to 18.0 #1833

Conversation

chaule97 commented Nov 6, 2024 • edited Loading

TDu left a comment

Choose a reason for hiding this comment

TDu commented Nov 6, 2024 • edited Loading

mmequignon Nov 7, 2024

Choose a reason for hiding this comment

chaule97 Nov 8, 2024

Choose a reason for hiding this comment

sebalix Dec 24, 2024

Choose a reason for hiding this comment

chaule97 commented Nov 8, 2024

TDu commented Nov 22, 2024

chaule97 commented Nov 22, 2024

ivantodorovich Dec 24, 2024

Choose a reason for hiding this comment

ivantodorovich Dec 24, 2024

Choose a reason for hiding this comment

ivantodorovich Dec 24, 2024

Choose a reason for hiding this comment

ivantodorovich Dec 24, 2024

Choose a reason for hiding this comment

OCA-git-bot commented Dec 24, 2024

chaule97 commented Nov 6, 2024 •

edited

Loading

TDu commented Nov 6, 2024 •

edited

Loading