[16.0][MIG] account_invoice_triple_discount: Migration to 16.0 #1269

ramiadavid · 2022-10-19T18:19:25Z

Migration to v16

legalsylvain · 2022-10-19T18:58:39Z

Hi. Thanks for porting this module.
I have a functional question. In my company I receive many supplier invoices with Discount 1 & 2. (Odoo 12.)
Some computation are good (I mean Odoo computation = supplier computation), but some computation are bad. That is due to the fact that the supplier makes intermediate rounding.
Do you think, it could be possible to introduce some computation option (depending on the supplier ?)

If yes, I can try to implement that extra feature.

Note : I think that this module is very complex. We should try to talk to the Odoo SA dev team in the next odoo experience to try to have some hook to avoid all this code. Don't you think ?

Kind regard.

ramiadavid · 2022-10-27T06:31:30Z

Hi. Thanks for porting this module. I have a functional question. In my company I receive many supplier invoices with Discount 1 & 2. (Odoo 12.) Some computation are good (I mean Odoo computation = supplier computation), but some computation are bad. That is due to the fact that the supplier makes intermediate rounding. Do you think, it could be possible to introduce some computation option (depending on the supplier ?)

If yes, I can try to implement that extra feature.

Note : I think that this module is very complex. We should try to talk to the Odoo SA dev team in the next odoo experience to try to have some hook to avoid all this code. Don't you think ?

Kind regard.

Hi @legalsylvain
In this module there is a bug in the calculation of discounts, it is discussed here #1240 , and I have uploaded a PR with the fix, I am waiting for it to be merged

Does this solve your problem?

legalsylvain · 2022-10-27T07:30:44Z

Hi @ramiadavid . thanks for your answer. it's différent topic. I talk about the fact that 2 results are valid depending on the supplier computation method.

FernandoRomera

Review, OK.

MRomeera

ok

Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_triple_discount Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_triple_discount/de/

Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_triple_discount Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_triple_discount/pt_BR/

… use discounts

Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_triple_discount Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_triple_discount/it/

Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_triple_discount Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_triple_discount/ca/

… with discount (cherry picked from commit 5afdb21)

sbejaoui

Hi,

Functional test

The invoice total don't match the lines subtotal.

ramiadavid · 2022-12-28T17:51:28Z

@sbejaoui @AntoniRomera @FernandoRomera @MRomeera

This is fixed, but I see that the discount_2 and discount_3 fields are only shown if we add the 'Technical / Discount on lines' group, while the discount field is always available, likewise the discount field is set to optional="hide" while than the other two as optional="show" and in the discount field the name is abbreviated "Disc." while in the others it says "Discount"

Wouldn't it be better to unify these things to follow the same criteria as the original field?

sbejaoui · 2022-12-29T07:45:28Z

Wouldn't it be better to unify these things to follow the same criteria as the original field?

+1,
Thank you

FernandoRomera · 2023-01-03T14:02:26Z

@ramiadavid
In account_invoice_triple_discount/report/invoice.xml, the names are:
Disc.2 %
Disc.3 %
without so many blanks and parentheses

ramiadavid · 2023-01-03T14:16:25Z

@ramiadavid In account_invoice_triple_discount/report/invoice.xml, the names are: Disc.2 % Disc.3 % without so many blanks and parentheses

You're right, I've already changed it.

lmignon

LGTM (Code review + functional) but the source term into the translation files must be updated with the new labels for the discount columns....

account_invoice_triple_discount/views/account_move.xml

lmignon

Thank you @ramiadavid for all this work. LGTM (Code review + functional)

account_invoice_triple_discount/models/account_move_line.py

lmignon · 2023-01-24T09:05:11Z

@OCA/accounting-maintainers Someone to merge this one?

adrienpeiffer · 2023-01-24T09:06:26Z

/ocabot merge nobump

OCA-git-bot · 2023-01-24T09:07:09Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1269-by-adrienpeiffer-bump-nobump, awaiting test results.

OCA-git-bot · 2023-01-24T09:12:41Z

Congratulations, your PR was merged at f6d904d. Thanks a lot for contributing to OCA. ❤️

lmignon · 2023-01-24T09:15:37Z

Thank you @adrienpeiffer for the merge!

tafaRU · 2023-09-05T13:10:52Z

/ocabot migration acount_invoice_triple_discount

Signed-off-by AaronHForgeFlow

ramiadavid changed the title ~~[16][MIG] account_invoice_triple_discount: Migration to 16.0~~ [16.0][MIG] account_invoice_triple_discount: Migration to 16.0 Oct 19, 2022

ramiadavid marked this pull request as ready for review October 19, 2022 18:22

ramiadavid force-pushed the 16.0-mig-account_invoice_triple_discount branch from c5c765c to 7fa0122 Compare October 26, 2022 19:56

FernandoRomera approved these changes Dec 19, 2022

View reviewed changes

MRomeera approved these changes Dec 19, 2022

View reviewed changes

OCA-git-bot added the approved label Dec 19, 2022

AntoniRomera approved these changes Dec 19, 2022

View reviewed changes

chienandalu and others added 20 commits December 20, 2022 08:39

account_invoice_triple_discount: New module

46d8b7d

account_invoice_triple_discount: Some improvements

aa4b11c

account_invoice_triple_discount

5ae60be

[MIG] account_invoice_triple_discount v11 to v12

37ec290

[UPD] Update account_invoice_triple_discount.pot

d799b50

[ADD] icon.png

f37cec1

[MIG] account_invoice_triple_discount to v13

46e1204

[IMP] account_invoice_triple_discount: black, isort, prettier

cd7a257

[14.0][MIG] account_invoice_triple_discount: Migration to V14

cba4f77

[FIX] account_invoice_triple_discount: Developer Mode was required to…

51bfff5

… use discounts

[IMP] update dotfiles

3c0d087

[MIG] account_invoice_triple_discount: Migration to 15.0

238921b

[UPD] Update account_invoice_triple_discount.pot

77a8808

[UPD] README.rst

866da14

[FIX] account_invoice_triple_discount: fix precision when compute tax…

1ecacd0

… with discount (cherry picked from commit 5afdb21)

[IMP] account_invoice_triple_discount: pre-commit stuff

008a8a3

sbejaoui suggested changes Dec 28, 2022

View reviewed changes

OCA-git-bot removed the approved label Dec 28, 2022

ramiadavid force-pushed the 16.0-mig-account_invoice_triple_discount branch 2 times, most recently from 8171b91 to cc65e60 Compare December 28, 2022 17:33

ramiadavid force-pushed the 16.0-mig-account_invoice_triple_discount branch from cc65e60 to 0c165eb Compare January 2, 2023 20:58

ramiadavid force-pushed the 16.0-mig-account_invoice_triple_discount branch from 0c165eb to e628d2a Compare January 3, 2023 14:13

lmignon suggested changes Jan 10, 2023

View reviewed changes

account_invoice_triple_discount/views/account_move.xml Show resolved Hide resolved

ramiadavid force-pushed the 16.0-mig-account_invoice_triple_discount branch from e628d2a to 9f5ba13 Compare January 12, 2023 13:43

lmignon approved these changes Jan 12, 2023

View reviewed changes

rousseldenis approved these changes Jan 13, 2023

View reviewed changes

account_invoice_triple_discount/models/account_move_line.py Outdated Show resolved Hide resolved

account_invoice_triple_discount/models/account_move_line.py Outdated Show resolved Hide resolved

account_invoice_triple_discount/models/account_move_line.py Outdated Show resolved Hide resolved

[MIG] account_invoice_triple_discount: Migration to 16.0

d2e12c0

ramiadavid force-pushed the 16.0-mig-account_invoice_triple_discount branch from 9f5ba13 to d2e12c0 Compare January 13, 2023 08:15

OCA-git-bot added the bot is merging ⏳ label Jan 24, 2023

OCA-git-bot merged commit fb78ef6 into OCA:16.0 Jan 24, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 24, 2023

ramiadavid deleted the 16.0-mig-account_invoice_triple_discount branch January 24, 2023 09:21

OCA-git-bot added this to the 16.0 milestone Sep 5, 2023

OCA-git-bot mentioned this pull request Sep 5, 2023

Migration to version 16.0 #1250

Open

64 tasks

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023

Merge PR OCA#1269 into 14.0

793c3c0

Signed-off-by AaronHForgeFlow

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_invoice_triple_discount: Migration to 16.0 #1269

[16.0][MIG] account_invoice_triple_discount: Migration to 16.0 #1269

ramiadavid commented Oct 19, 2022 •

edited

Loading

legalsylvain commented Oct 19, 2022

ramiadavid commented Oct 27, 2022

legalsylvain commented Oct 27, 2022

FernandoRomera left a comment

MRomeera left a comment

sbejaoui left a comment

ramiadavid commented Dec 28, 2022

sbejaoui commented Dec 29, 2022

FernandoRomera commented Jan 3, 2023

ramiadavid commented Jan 3, 2023

lmignon left a comment •

edited

Loading

lmignon left a comment

lmignon commented Jan 24, 2023

adrienpeiffer commented Jan 24, 2023

OCA-git-bot commented Jan 24, 2023

OCA-git-bot commented Jan 24, 2023

lmignon commented Jan 24, 2023

tafaRU commented Sep 5, 2023

[16.0][MIG] account_invoice_triple_discount: Migration to 16.0 #1269

[16.0][MIG] account_invoice_triple_discount: Migration to 16.0 #1269

Conversation

ramiadavid commented Oct 19, 2022 • edited Loading

legalsylvain commented Oct 19, 2022

ramiadavid commented Oct 27, 2022

legalsylvain commented Oct 27, 2022

FernandoRomera left a comment

Choose a reason for hiding this comment

MRomeera left a comment

Choose a reason for hiding this comment

sbejaoui left a comment

Choose a reason for hiding this comment

ramiadavid commented Dec 28, 2022

sbejaoui commented Dec 29, 2022

FernandoRomera commented Jan 3, 2023

ramiadavid commented Jan 3, 2023

lmignon left a comment • edited Loading

Choose a reason for hiding this comment

lmignon left a comment

Choose a reason for hiding this comment

lmignon commented Jan 24, 2023

adrienpeiffer commented Jan 24, 2023

OCA-git-bot commented Jan 24, 2023

OCA-git-bot commented Jan 24, 2023

lmignon commented Jan 24, 2023

tafaRU commented Sep 5, 2023

ramiadavid commented Oct 19, 2022 •

edited

Loading

lmignon left a comment •

edited

Loading