-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] account_analytic_document_date: New module account_analyt… #694
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] account_analytic_document_date: New module account_analyt… #694
Conversation
2e75749
to
6066e28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code review and tested in runboat
6066e28
to
a8f05bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
73bc5d2
to
edd9720
Compare
@pedrobaeza Could you review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the goal of having another date. I would understand that you want a different date for the analytic line, but not having dual dates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be ca.po
e66c942
to
d2bc8be
Compare
d2bc8be
to
f7a8703
Compare
@pedrobaeza For instance, if an invoice is created in December but refers to sales made in November, the Accrual Date allows us to reflect this correctly in our accounting records. This ensures compliance with accrual-based accounting principles and provides better insights into the financial period to which transactions belong. This feature is particularly valuable for businesses that need to differentiate between the accounting period of transaction occurrence and the timing of document issuance. |
class AccountMove(models.Model): | ||
_inherit = "account.move" | ||
|
||
document_date = fields.Date() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's a date only for analytic, it shouldn't be called document_date
, but analytic_document_date
or analytic_date
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it is used for analytic purposes, but it is also visible in the account module, so it serves both purposes. For this reason, I believe the name 'document_date' remains appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it creates confusion on users thinking that date is going to be used for example for financial reports. It should be renamed to analytic_document_date
IMO.
f7a8703
to
d16a0c3
Compare
This module adds an other date to the account.move for analytics proposits
Usage:
Set Document Date on Invoice:
Analytic Line Generation:
Setting Document Date in Reconcile View:
cc https://github.com/APSL 160768
@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 @ppyczko please review