Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OU-ADD] spreadsheet. Nothing to do #4641

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[OU-ADD] spreadsheet. Nothing to do #4641

merged 1 commit into from
Jan 22, 2025

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Oct 27, 2024 •
edited
Loading

@legalsylvain
Copy link
Contributor Author

legalsylvain commented Oct 27, 2024 •
edited
Loading

/ocabot migration spreadsheet

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 27, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 27, 2024
Open
@hbrunn
Copy link
Member

hbrunn commented Oct 28, 2024

given the actual data lives in a json blob, did you check if we need to convert that? As in, can we open a spreadsheet created in v16 with v17?

@legalsylvain
Copy link
Contributor Author

did you check if we need to convert that?

No, I didn't checked. I'll give it a try and tell you.

Thanks for your question !

@pedrobaeza
Copy link
Member

The spreadsheet library includes their own migration engine, and it's included in the main community module. My only doubt is if it's auto-run on opening or not.

hbrunn
hbrunn approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just diffed a couple of spreadsheet definitions between v16 and v17, and they all have the same version with just some data changes, so I think this is fine.

@legalsylvain legalsylvain force-pushed the 17.0-OU-ADD-spreadsheet branch from 4e13ae8 to 6b65e30 Compare December 10, 2024 14:21
@MiquelRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-4641-by-MiquelRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 06b76c7 into OCA:17.0 Jan 22, 2025
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 06b76c7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrunn hbrunn hbrunn approved these changes

Assignees
No one assigned
Labels
Dependency OK merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@legalsylvain @hbrunn @pedrobaeza @MiquelRForgeFlow @OCA-git-bot