[16.0][MIG] hr_recruitment: Migration scripts #4296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration hr_recruitment |
|
The migration issue (#3681) has not been updated to reference the current pull request because a previous pull request (#3994) is not closed. |
robinkeunen
force-pushed
the
16.0-hr_recruitment-mig
branch
2 times, most recently
from
bfc3b45
to
70d1d9d
Compare
remytms
suggested changes
Feb 19, 2024
openupgrade_scripts/scripts/hr_recruitment/16.0.1.1/noupdate_changes.xml
Outdated
Show resolved
Hide resolved
openupgrade_scripts/scripts/hr_recruitment/16.0.1.1/noupdate_changes.xml
Outdated
Show resolved
Hide resolved
robinkeunen
force-pushed
the
16.0-hr_recruitment-mig
branch
2 times, most recently
from
98d114d
to
f70a4cc
Compare
pedrobaeza
changed the title
|
/ocabot migration hr_recruitment |
victoralmau
suggested changes
Feb 26, 2024
openupgrade_scripts/scripts/hr_recruitment/16.0.1.1/post-migration.py
Outdated
Show resolved
Hide resolved
This was referenced Feb 27, 2024
robinkeunen
force-pushed
the
16.0-hr_recruitment-mig
branch
from
f70a4cc
to
d5a49d0
Compare
pedrobaeza
requested changes
Feb 28, 2024
openupgrade_scripts/scripts/hr_recruitment/16.0.1.1/noupdate_changes.xml
Outdated
Show resolved
Hide resolved
openupgrade_scripts/scripts/hr_recruitment/16.0.1.1/upgrade_analysis_work.txt
Outdated
Show resolved
Hide resolved
openupgrade_scripts/scripts/hr_recruitment/16.0.1.1/upgrade_analysis_work.txt
Outdated
Show resolved
Hide resolved
robinkeunen
force-pushed
the
16.0-hr_recruitment-mig
branch
from
d5a49d0
to
087b8d2
Compare
robinkeunen
force-pushed
the
16.0-hr_recruitment-mig
branch
from
087b8d2
to
e9df526
Compare
|
Thanks for the review, I fixed accordingly. |
pedrobaeza
reviewed
Mar 1, 2024
| from openupgradelib import openupgrade | ||
|
|
||
| translations_to_delete = [ | ||
| "group_hr_recruitment_user", |
There was a problem hiding this comment.
The translations you have to delete are the mail template ones:
Suggested change
| "group_hr_recruitment_user", | |
| "email_template_data_applicant_congratulations", | |
| "email_template_data_applicant_interest", |
|
As we need to move forward with dependent modules, I'm superseding this in #4333 with my latest comment attended. Thanks for the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #3994
@victoralmau I deleted the fields from the noupdate if the odoo15 template was still valid. I'm not sure this is the way to do, I can reintroduce it if needed.