Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema #1420

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Update schema #1420

merged 1 commit into from
Jan 22, 2021

Conversation

matentzn
Copy link
Contributor

No description provided.

@jamesaoverton
Copy link
Member

I looked through the code pretty carefully, and it looks fine.

But I'm worried that the changes to registry/obo_context.jsonld will break stuff, especially once ROBOT is updated to use them. On the other hand, it might also fix things that are currently broken...

But I don't know how to properly test it. Do you have a plan @matentzn ?

@matentzn
Copy link
Contributor Author

My main concern is that robot gets the new and updated curie map of the context before it's next release (needed for dashboard) but I don't know exactly what could break.. in your experience, what are the risks?

@jamesaoverton
Copy link
Member

See also prefixcommons/biocontext#33

Copy link
Member

@jamesaoverton jamesaoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed case is correct for these ontologies (ExO, HsapDv, MmusDv, OlatDv, PdumDv) based on their own OWL files and their PURL configs, which @matentzn and I both double-checked. I also double-checked OLS. @matentzn grepped through all the OBO OWL files looking for the uppercase versions of these five IDSPACEs and did not find any.

So I'm fairly confident that this change will fix things and not break anything.

@matentzn matentzn merged commit 2b88814 into master Jan 22, 2021
@matentzn matentzn deleted the update_meta branch January 22, 2021 16:57
jamesaoverton added a commit to ontodev/robot that referenced this pull request Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants