Skip to content

Add 2 new properties for fuzzy positions #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions faldo.ttl
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,13 @@
rdf:type owl:Class ;
rdfs:comment "A position that lacks exact data."^^xsd:string ;
rdfs:label "Fuzzy position"^^xsd:string ;
rdfs:subClassOf :Position .
rdfs:subClassOf :Position ;
rdfs:subClassOf
[ rdf:type owl:Restriction ;
owl:onProperty :probability ;
owl:maxQualifiedCardinality "1"^^xsd:nonNegativeInteger ;
owl:onDataRange owl:float
] .

:InBetweenPosition
rdf:type owl:Class ;
Expand Down Expand Up @@ -136,7 +142,13 @@
rdf:type owl:Class ;
rdfs:comment "The position is known to be one of the more detailed positions listed by the location predicate."^^xsd:string ;
rdfs:label "One of positions"^^xsd:string ;
rdfs:subClassOf :FuzzyPosition ;
rdfs:subClassOf :FuzzyPosition ;
rdfs:subClassOf
[ rdf:type owl:Restriction ;
owl:onProperty :possiblePosition ;
owl:minQualifiedCardinality "1"^^xsd:nonNegativeInteger ;
owl:onClass :Position
] ;
owl:disjointWith :ExactPosition , :InRangePosition , :InBetweenPosition .

:Position
Expand Down Expand Up @@ -252,4 +264,23 @@
:reference
rdf:type owl:ObjectProperty ;
rdfs:comment "The reference is the resource that the position value is anchored to. For example, a contig or chromosome in a genome assembly."^^xsd:string ;
rdfs:label "reference"^^xsd:string .
rdfs:label "reference"^^xsd:string .

:possiblePosition
rdf:type owl:ObjectProperty ;
rdfs:comment "One of the possible positions listed for a OneOfPosition element."^^xsd:string ; ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line ends with ; ; instead of just one. could lead to issues.

rdfs:label "possiblePosition"^^xsd:string ;
rdfs:domain :OneOfPosition ;
rdfs:range :Position .

:probability
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the probability part should come in a different pull request. I think for clean modelling it should be inverted and should not be attached to :FuzzyPosition as even an :ExactPosition can have a probability funcion associated with it.

rdfs:type owl:DatatypeProperty ;
rdfs:comment "A probability value possibly attached to a fuzzy position."^^xsd:string ;
rdfs:label "probability"^^xsd:string ;
rdfs:domain :FuzzyPosition ;
rdfs:range
[ rdf:type rdfs:Datatype ;
owl:onDatatype xsd:float ;
owl:withRestrictions
([ xsd:minInclusive "0.0"^^xsd:float ] [ xsd:maxInclusive "1.0"^^xsd:float])
] .