-
Notifications
You must be signed in to change notification settings - Fork 11
Add 2 new properties for fuzzy positions #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ljgarcia
wants to merge
1
commit into
OBF:master
Choose a base branch
from
ljgarcia:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,13 @@ | |
rdf:type owl:Class ; | ||
rdfs:comment "A position that lacks exact data."^^xsd:string ; | ||
rdfs:label "Fuzzy position"^^xsd:string ; | ||
rdfs:subClassOf :Position . | ||
rdfs:subClassOf :Position ; | ||
rdfs:subClassOf | ||
[ rdf:type owl:Restriction ; | ||
owl:onProperty :probability ; | ||
owl:maxQualifiedCardinality "1"^^xsd:nonNegativeInteger ; | ||
owl:onDataRange owl:float | ||
] . | ||
|
||
:InBetweenPosition | ||
rdf:type owl:Class ; | ||
|
@@ -136,7 +142,13 @@ | |
rdf:type owl:Class ; | ||
rdfs:comment "The position is known to be one of the more detailed positions listed by the location predicate."^^xsd:string ; | ||
rdfs:label "One of positions"^^xsd:string ; | ||
rdfs:subClassOf :FuzzyPosition ; | ||
rdfs:subClassOf :FuzzyPosition ; | ||
rdfs:subClassOf | ||
[ rdf:type owl:Restriction ; | ||
owl:onProperty :possiblePosition ; | ||
owl:minQualifiedCardinality "1"^^xsd:nonNegativeInteger ; | ||
owl:onClass :Position | ||
] ; | ||
owl:disjointWith :ExactPosition , :InRangePosition , :InBetweenPosition . | ||
|
||
:Position | ||
|
@@ -252,4 +264,23 @@ | |
:reference | ||
rdf:type owl:ObjectProperty ; | ||
rdfs:comment "The reference is the resource that the position value is anchored to. For example, a contig or chromosome in a genome assembly."^^xsd:string ; | ||
rdfs:label "reference"^^xsd:string . | ||
rdfs:label "reference"^^xsd:string . | ||
|
||
:possiblePosition | ||
rdf:type owl:ObjectProperty ; | ||
rdfs:comment "One of the possible positions listed for a OneOfPosition element."^^xsd:string ; ; | ||
rdfs:label "possiblePosition"^^xsd:string ; | ||
rdfs:domain :OneOfPosition ; | ||
rdfs:range :Position . | ||
|
||
:probability | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the probability part should come in a different pull request. I think for clean modelling it should be inverted and should not be attached to :FuzzyPosition as even an :ExactPosition can have a probability funcion associated with it. |
||
rdfs:type owl:DatatypeProperty ; | ||
rdfs:comment "A probability value possibly attached to a fuzzy position."^^xsd:string ; | ||
rdfs:label "probability"^^xsd:string ; | ||
rdfs:domain :FuzzyPosition ; | ||
rdfs:range | ||
[ rdf:type rdfs:Datatype ; | ||
owl:onDatatype xsd:float ; | ||
owl:withRestrictions | ||
([ xsd:minInclusive "0.0"^^xsd:float ] [ xsd:maxInclusive "1.0"^^xsd:float]) | ||
] . |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line ends with ; ; instead of just one. could lead to issues.