This repository was archived by the owner on Jul 3, 2020. It is now read-only.
Minor fixes - NPE checks and additional client validations #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuthValidator : Fixed a typo OAuthValidatorImpl : Handling the scenario where the access token request contains a blank client id TokenResource : Authorization Code Grant flow does not verify that the authorization code was granted to the same client which is making the request for token now. Fixed this.ALso put in the same check while reissuing a token with a refresh token
|
Hi @preetilovekar, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthenticationFilter : Added check to see if the redirectURI is absent
OAuthValidator : Fixed a typo
OAuthValidatorImpl : Handling the scenario where the access token request contains a blank client id
TokenResource : Authorization Code Grant flow does not verify that the authorization code was granted to the same client which is making the request for token now. Fixed this.Also put in the same check while reissuing a token with a refresh token